Skip to content

fix(components): display correct wells for tip pick up in all nozzle configurations#21246

Open
rclarke0 wants to merge 3 commits intoedgefrom
AUTH-2223
Open

fix(components): display correct wells for tip pick up in all nozzle configurations#21246
rclarke0 wants to merge 3 commits intoedgefrom
AUTH-2223

Conversation

@rclarke0
Copy link
Copy Markdown
Contributor

@rclarke0 rclarke0 commented Apr 9, 2026

Overview

Correctly display tips being picked up for all nozzle configurations

Test Plan and Hands on Testing

  • smoke tested on the app to ensure the step says accessing tips "A1 - A12"
Screenshot 2026-04-09 at 5 38 34 PM

Changelog

  • added additional case for when there are 12 active nozzles
  • added additional case for when there are partial 8ch active nozzles

Review requests

none

Risk assessment

  • low cosmetic change

closes AUTH-2223

@rclarke0 rclarke0 requested a review from a team as a code owner April 9, 2026 21:47
@rclarke0 rclarke0 requested review from SyntaxColoring and jerader and removed request for a team April 9, 2026 21:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 31.81818% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.19%. Comparing base (1c17900) to head (d45c8ab).
⚠️ Report is 43 commits behind head on edge.

Files with missing lines Patch % Lines
...andText/useCommandTextString/utils/getWellRange.ts 31.81% 30 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #21246      +/-   ##
==========================================
- Coverage   57.20%   57.19%   -0.01%     
==========================================
  Files        3987     3987              
  Lines      326739   326823      +84     
  Branches    46475    46485      +10     
==========================================
+ Hits       186908   186929      +21     
- Misses     139612   139675      +63     
  Partials      219      219              
Flag Coverage Δ
app 44.92% <31.81%> (-0.02%) ⬇️
protocol-designer 19.93% <2.27%> (-0.01%) ⬇️
step-generation 5.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/command/types/setup.ts 100.00% <ø> (ø)
...andText/useCommandTextString/utils/getWellRange.ts 54.16% <31.81%> (+8.51%) ⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rclarke0 rclarke0 changed the title fix(components): display correct wells for tip pick up in ROW configuration fix(components): display correct wells for tip pick up in all nozzle configurations Apr 10, 2026
@rclarke0 rclarke0 requested a review from a team as a code owner April 10, 2026 17:16
@rclarke0 rclarke0 requested a review from CaseyBatten April 17, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant