fix(protocol-designer): use well size from each well rather than the first one#21239
Merged
rclarke0 merged 4 commits intochore_release-pd-8.10.0from Apr 13, 2026
Merged
fix(protocol-designer): use well size from each well rather than the first one#21239rclarke0 merged 4 commits intochore_release-pd-8.10.0from
rclarke0 merged 4 commits intochore_release-pd-8.10.0from
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.10.0 #21239 +/- ##
===========================================================
- Coverage 55.29% 55.29% -0.01%
===========================================================
Files 4003 4003
Lines 339079 339090 +11
Branches 51843 51851 +8
===========================================================
- Hits 187490 187488 -2
- Misses 151371 151384 +13
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ncdiehl11
approved these changes
Apr 10, 2026
| render( | ||
| <TipStatus | ||
| type="new" | ||
| size={'20'} |
Collaborator
There was a problem hiding this comment.
you can unbracket all of these
| wellMap: LabwareWellMap | ||
| wellName: string | ||
| size?: string | ||
| size: string |
Collaborator
There was a problem hiding this comment.
do we want to require this prop?
Contributor
Author
There was a problem hiding this comment.
yes to ensure the well size is always passed in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Pass in the individual well size rather than relying on using the size of the first well.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
Closes RQA-5319