Skip to content

fix(protocol-designer): use well size from each well rather than the first one#21239

Merged
rclarke0 merged 4 commits intochore_release-pd-8.10.0from
RQA-5319
Apr 13, 2026
Merged

fix(protocol-designer): use well size from each well rather than the first one#21239
rclarke0 merged 4 commits intochore_release-pd-8.10.0from
RQA-5319

Conversation

@rclarke0
Copy link
Copy Markdown
Contributor

@rclarke0 rclarke0 commented Apr 9, 2026

Overview

Pass in the individual well size rather than relying on using the size of the first well.

Test Plan and Hands on Testing

  • smoke tested with protocol attached in RQA-5319 and confirmed well sizes are accurate:
Screenshot 2026-04-09 at 4 33 11 PM Screenshot 2026-04-09 at 4 33 23 PM

Changelog

  • passed the well size in from StaticLabware and made the size property required.
  • adjusted logic that was using size as a determiner of other variables now that it is always required

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

  • low, cosmetic

Closes RQA-5319

@rclarke0 rclarke0 requested a review from a team as a code owner April 9, 2026 20:41
@rclarke0 rclarke0 requested review from jerader and ncdiehl11 and removed request for a team April 9, 2026 20:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.29%. Comparing base (8deddbc) to head (305de08).
⚠️ Report is 1 commits behind head on chore_release-pd-8.10.0.

Files with missing lines Patch % Lines
...im/Labware/labwareInternals/Wells/SelectedWell.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           chore_release-pd-8.10.0   #21239      +/-   ##
===========================================================
- Coverage                    55.29%   55.29%   -0.01%     
===========================================================
  Files                         4003     4003              
  Lines                       339079   339090      +11     
  Branches                     51843    51851       +8     
===========================================================
- Hits                        187490   187488       -2     
- Misses                      151371   151384      +13     
  Partials                       218      218              
Flag Coverage Δ
app 45.16% <25.00%> (-0.01%) ⬇️
protocol-designer 19.96% <0.00%> (ø)
step-generation 5.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...are-sim/Labware/labwareInternals/StaticLabware.tsx 74.45% <100.00%> (+0.18%) ⬆️
...re-sim/Labware/labwareInternals/Tips/TipStatus.tsx 29.78% <ø> (-5.63%) ⬇️
...-sim/Labware/labwareInternals/Wells/WellStatus.tsx 28.88% <ø> (ø)
...im/Labware/labwareInternals/Wells/SelectedWell.tsx 2.66% <0.00%> (+0.03%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

render(
<TipStatus
type="new"
size={'20'}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can unbracket all of these

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also

wellMap: LabwareWellMap
wellName: string
size?: string
size: string
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to require this prop?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes to ensure the well size is always passed in

@rclarke0 rclarke0 merged commit fd9021f into chore_release-pd-8.10.0 Apr 13, 2026
81 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants