Skip to content

fix(protocol-designer): add lines delineating deck expansion slots#21223

Closed
rclarke0 wants to merge 5 commits intochore_release-pd-8.10.0from
RQA-5309
Closed

fix(protocol-designer): add lines delineating deck expansion slots#21223
rclarke0 wants to merge 5 commits intochore_release-pd-8.10.0from
RQA-5309

Conversation

@rclarke0
Copy link
Copy Markdown
Contributor

@rclarke0 rclarke0 commented Apr 7, 2026

Overview

Show a line delineating deck expansion slot vs deck slot

Test Plan and Hands on Testing

smoke tested starting deck and protocol starting deck with all expansion slots and waste chute and an expansion slot and a flex stacker

image Screenshot 2026-04-07 at 3 34 25 PM Screenshot 2026-04-07 at 3 34 40 PM Screenshot 2026-04-08 at 12 08 03 PM Screenshot 2026-04-08 at 12 08 14 PM

Changelog

  • used a middle slot svg and transformed it to sit in the appropriate spot on the deck
  • filtered out cutoutIds that were being used as staging slots so that two slot renders would not occur

Review requests

  • is there anywhere else in pd that the deck is displayed?

Risk assessment

  • medium

Closes RQA-5309

@rclarke0 rclarke0 requested a review from a team as a code owner April 7, 2026 19:37
@rclarke0 rclarke0 changed the title Rqa 5309 fix(protocol-designer): add lines delineating deck expansion slots Apr 7, 2026
@rclarke0 rclarke0 requested review from SyntaxColoring, jerader and ncdiehl11 and removed request for a team April 7, 2026 19:42
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 31.30435% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.28%. Comparing base (a981b04) to head (be4c372).
⚠️ Report is 17 commits behind head on chore_release-pd-8.10.0.

Files with missing lines Patch % Lines
...s/src/hardware-sim/BaseDeck/StagingAreaFixture.tsx 0.00% 54 Missing ⚠️
...ware-sim/BaseDeck/WasteChuteStagingAreaFixture.tsx 0.00% 20 Missing ⚠️
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 78.26% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           chore_release-pd-8.10.0   #21223      +/-   ##
===========================================================
- Coverage                    55.47%   55.28%   -0.20%     
===========================================================
  Files                         4003     4003              
  Lines                       338995   339183     +188     
  Branches                     51847    51885      +38     
===========================================================
- Hits                        188071   187510     -561     
- Misses                      150701   151455     +754     
+ Partials                       223      218       -5     
Flag Coverage Δ
app 45.15% <0.00%> (-0.25%) ⬇️
protocol-designer 19.96% <31.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ts/src/hardware-sim/BaseDeck/WasteChuteFixture.tsx 14.15% <ø> (+0.59%) ⬆️
...igner/src/pages/ProtocolOverview/DeckThumbnail.tsx 71.85% <100.00%> (+2.29%) ⬆️
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 51.35% <78.26%> (+1.49%) ⬆️
...ware-sim/BaseDeck/WasteChuteStagingAreaFixture.tsx 4.76% <0.00%> (-0.70%) ⬇️
...s/src/hardware-sim/BaseDeck/StagingAreaFixture.tsx 2.25% <0.00%> (-0.58%) ⬇️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rclarke0 rclarke0 marked this pull request as draft April 8, 2026 13:24
@ncdiehl11
Copy link
Copy Markdown
Collaborator

The possible cutout fixtures to test are:

  1. staging area right
  2. waste chute + staging area right
  3. waste chute (w/o staging area)
  4. single right slot (w/o staging area)

Is that right? If so, the delineation should show for fixtures 1 and 2 above, but not for 3 and 4?

@rclarke0 rclarke0 marked this pull request as ready for review April 8, 2026 16:20
@rclarke0 rclarke0 marked this pull request as draft April 8, 2026 19:27
@rclarke0
Copy link
Copy Markdown
Contributor Author

opened different one that is based off edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants