fix(protocol-designer): add lines delineating deck expansion slots#21223
Closed
rclarke0 wants to merge 5 commits intochore_release-pd-8.10.0from
Closed
fix(protocol-designer): add lines delineating deck expansion slots#21223rclarke0 wants to merge 5 commits intochore_release-pd-8.10.0from
rclarke0 wants to merge 5 commits intochore_release-pd-8.10.0from
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.10.0 #21223 +/- ##
===========================================================
- Coverage 55.47% 55.28% -0.20%
===========================================================
Files 4003 4003
Lines 338995 339183 +188
Branches 51847 51885 +38
===========================================================
- Hits 188071 187510 -561
- Misses 150701 151455 +754
+ Partials 223 218 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
|
The possible cutout fixtures to test are:
Is that right? If so, the delineation should show for fixtures 1 and 2 above, but not for 3 and 4? |
Contributor
Author
|
opened different one that is based off edge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Show a line delineating deck expansion slot vs deck slot
Test Plan and Hands on Testing
smoke tested starting deck and protocol starting deck with all expansion slots and waste chute and an expansion slot and a flex stacker
Changelog
Review requests
Risk assessment
Closes RQA-5309