fix(abr-testing): remove meniscus steps from stacker protocol#21220
Merged
alexjoel42 merged 5 commits intoedgefrom Apr 17, 2026
Merged
fix(abr-testing): remove meniscus steps from stacker protocol#21220alexjoel42 merged 5 commits intoedgefrom
alexjoel42 merged 5 commits intoedgefrom
Conversation
The meniscus values caused the pipette to crash into the deck. We are removing .meniscus and updating the API level to avoid this
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #21220 +/- ##
=======================================
Coverage 57.33% 57.33%
=======================================
Files 3991 3991
Lines 327447 327447
Branches 46648 46648
=======================================
Hits 187756 187756
Misses 139472 139472
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
skowalski08
reviewed
Apr 17, 2026
| location=FRERAT.meniscus(z=-1, target="start"), | ||
| end_location=FRERAT.meniscus(z=-1, target="end"), | ||
| ) | ||
| p1000.aspirate(FRERATVol + 1, location=FRERAT.bottom()) |
Contributor
There was a problem hiding this comment.
I would suggest adding a value to .bottom, or a param for .bottom() cause i suspect we'll see overpressures
Contributor
Author
There was a problem hiding this comment.
Good golly, I am so glad you caught this. It used to default to 0.5mm I think a very long time ago and I bamboozled myself.
skowalski08
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meniscus values caused the pipette to crash into the deck. We are removing .meniscus and updating the API level to avoid this
Overview
We saw crashes because the pipette wanted to go below the labware. These weren't happening before because in previous API level the labware version was 4 and therefore there was ever so slightly more wiggle room to allow for bad protocol behavior.
Test Plan and Hands on Testing
Run ABR11 (ongoing)