Skip to content

refactor(app): clear styled-components out of LabwareDetails and HistoricalRunProtocol#21166

Merged
nataliet87 merged 5 commits intoedgefrom
app_refactor-styled-components
Apr 15, 2026
Merged

refactor(app): clear styled-components out of LabwareDetails and HistoricalRunProtocol#21166
nataliet87 merged 5 commits intoedgefrom
app_refactor-styled-components

Conversation

@nataliet87
Copy link
Copy Markdown
Contributor

@nataliet87 nataliet87 commented Apr 1, 2026

Overview

Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources.

This change updates the syntax from styled-components to modules.css in App LabwareDetails and HistoricalRunProtocol files.

Test Plan and Hands on Testing

Ran make -C app dev and verify that everything looks good.

Changelog

styled-components usage removed from LabwareDetails/index.tsx and HistoricalRunProtocol.tsx files with module.css files added holding component definitions.

Review requests

  • Take a look and make sure the screenshots match between orig and updated app appearance.

Risk assessment

  • Low risk

@nataliet87
Copy link
Copy Markdown
Contributor Author

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.20%. Comparing base (6af59fc) to head (0119964).
⚠️ Report is 43 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #21166      +/-   ##
==========================================
- Coverage   57.20%   57.20%   -0.01%     
==========================================
  Files        3987     3987              
  Lines      326741   326735       -6     
  Branches    46475    46473       -2     
==========================================
- Hits       186910   186898      -12     
- Misses     139612   139618       +6     
  Partials      219      219              
Flag Coverage Δ
app 44.93% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rganisms/Desktop/Devices/HistoricalProtocolRun.tsx 78.00% <100.00%> (-6.32%) ⬇️
...organisms/Desktop/Labware/LabwareDetails/index.tsx 76.96% <100.00%> (-0.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!


Some GitHub tips:

  • GitHub auto-created the PR title App refactor styled components from your branch name app_refactor-styled-components. When you get the chance, edit it to the format like refactor(app): Blah blah. That'll make it easier to scan in the PR list. And it'll help generate the correct commit name later, when this PR is approved and you merge it into edge.

  • Instead of (or in addition to) @-mentioning people in a comment, you can name them as reviewers in the "Reviewers" section in the top-right. That way, the PR will show up on their side as "review requested" instead of just "mentioned," which can help with filtering and notifications.

  • Just a reminder, before un-drafting this, try to fill out the PR template to the best of your ability. And since this is your first PR, also read through our PR etiquette guidelines, if you haven't already. (I think you'll be good, I'm just making sure someone's introduced you to those at least once.)

    Feel free to run stuff by us if you're not sure.

    I know it can feel like a lot of formality the first time, sorry. It'll feel more casual as you keep going.


Below are some comments about the code.

Comment thread app/src/organisms/Desktop/AdvancedSettings/OT2AdvancedSettings.tsx Outdated
Comment thread app/src/organisms/Desktop/Devices/HistoricalProtocolRun.tsx
@nataliet87 nataliet87 force-pushed the app_refactor-styled-components branch from f7df3cc to 2b202ae Compare April 8, 2026 18:02
@nataliet87 nataliet87 changed the title App refactor styled components refactor(app): clear styled-components out of LabwareDetails and HistoricalRunProtocol Apr 8, 2026
@nataliet87 nataliet87 requested a review from TamarZanzouri April 8, 2026 18:04
@nataliet87 nataliet87 marked this pull request as ready for review April 9, 2026 14:00
Copy link
Copy Markdown
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change LGTM once CI is green! if you can add screemshots if would be helpful

Copy link
Copy Markdown
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Some final reminders when you click the merge button:

  • Make sure the first line (the summary) matches our commit message conventions. It should look like refactor(app): clear styled-components out of LabwareDetails and HistoricalRunProtocol (#21166), matching the PR title.

  • Replace the extended description with something concise. What to include is largely your discretion, but definitely make sure that you delete any junk left over from the PR template, like "Describe your PR at a high level...."

    One reasonable extended description would be just a copy-paste of your Overview section. i.e.

    This change updates the syntax from styled-components to modules.css in App LabwareDetails and HistoricalRunProtocol files.

From https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#after-receiving-pr-approval

@nataliet87
Copy link
Copy Markdown
Contributor Author

Oh shoot, I'm not sure what happened to the screenshots I'd thought I attached @TamarZanzouri

Trying again here:

  • Historical protocol run name style:
    • Original:
opentrons_hist_protocol_run_name_style_orig
  • New:
opentrons_hist_protocol_run_name_style_new
  • Labware name copy hover style:
    • Original:
opentrons_labware_name_copy_hover_orig - New: opentrons_labware_name_copy_hover_new
  • Labware name copy active style:
    • Original:
opentrons_labware_name_copy_active_orig - New: opentrons_labware_name_copy_active_new
  • Labware name close window hover style:
    • Original:
opentrons_close_labware_window_hover_orig - New: opentrons_close_labware_window_hover_new
  • Labware name close window active style:
    • Original:
opentrons_close_labware_window_active_new - New: opentrons_close_labware_window_active_orig

@nataliet87 nataliet87 merged commit ed8ff8a into edge Apr 15, 2026
54 checks passed
@nataliet87 nataliet87 deleted the app_refactor-styled-components branch April 15, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants