Make macOS DMG filename arch-aware (arm64 / x86_64)#6004
Open
geekrebel wants to merge 1 commit into
Open
Conversation
…roduce OpenShot-<version>-arm64.dmg while Intel Mac builds continue to produce OpenShot-<version>-x86_64.dmg. Arch is detected via platform.machine(); any non-arm64 value (including Rosetta-translated Python on Apple Silicon) keeps the existing x86_64 suffix, so Intel Mac build pipelines are byte-identical. This lets both Intel and Apple Silicon DMGs coexist in the mac release bucket once an arm64 runner is available, without renaming or displacing existing Intel downloads. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Darwinbranch ofinstaller/build_server.pycurrently hard-codes-x86_64.dmgas the DMG suffix. That name is fine on Intel Macs butmis-labels any Apple Silicon build, and (more importantly) would prevent an
arm64 and an Intel DMG from coexisting under
releases.openshot.org/mac/.This PR detects the arch via
platform.machine():arm64producesOpenShot-<version>-arm64.dmg.produces
OpenShot-<version>-x86_64.dmg, which is byte-identical totoday's name.
So there is no observable change for existing Intel Mac build pipelines.
Once an Apple Silicon runner is available, it will produce a clearly
labelled
-arm64.dmgartifact that can sit alongside the Intel one.The Linux AppImage and Windows
.exesuffixes are left untouched; theyare still
x86_64-only in practice, and changing them is out of scopefor this PR.
This is the second in a small series of Apple Silicon PRs (following
#6003, the "Apple VideoToolbox" label rename). The next planned change
is replacing the hard-coded
/usr/local/Cellar/python@3.7/3.7.9_2/...PATH in
installer/build-mac-dmg.sh, which is required before any arm64Homebrew (
/opt/homebrew) machine can run the mac packaging scriptend-to-end.