Skip to content

fix: null worker postMessage crash in withRealTimeUpdates HOC #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priscila-moneo wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −22
Open

fix: null worker postMessage crash in withRealTimeUpdates HOC #199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions src/utils/real_time_updates/withRealTimeUpdates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,11 @@ const withRealTimeUpdates = WrappedComponent => {
* @returns {Promise<void>}
*/
async processUpdates(updates) {

const {summit, allEvents, allIDXEvents, allSpeakers, allIDXSpeakers, synchEntityData} = this.props;

if(!this._worker)
{
console.log('withRealTimeUpdates::processUpdates worker is null');
const worker = this._worker;
if (!worker) {
console.log('withRealTimeUpdates::processUpdates worker is null (early return)');
return;
}

Expand All @@ -87,9 +86,15 @@ const withRealTimeUpdates = WrappedComponent => {
accessToken = await getAccessToken();
} catch (e) {
console.log('withRealTimeUpdates::processUpdates getAccessToken error: ', e);
return;
}

this._worker.postMessage({
if (worker !== this._worker) {
console.log('withRealTimeUpdates::processUpdates worker changed or was destroyed (post-await)');
return;
}

worker.postMessage({
accessToken: accessToken,
noveltiesArray: JSON.stringify(updates),
summit: JSON.stringify(summit),
Expand All @@ -100,31 +105,28 @@ const withRealTimeUpdates = WrappedComponent => {
currentLocation: this.getCurrentLocation()
});

this._worker.onmessage = ({
data: {
payload,
entity,
summit,
eventsData,
allIDXEvents: newAllIDXEvents,
allSpeakers: newAllSpeakers,
allIDXSpeakers: newAllIDXSpeakers
}
}) => {

worker.onmessage = ({
data: {
payload,
entity,
summit,
eventsData,
allIDXEvents: newAllIDXEvents,
allSpeakers: newAllSpeakers,
allIDXSpeakers: newAllIDXSpeakers
}
}) => {
console.log('withRealTimeUpdates::processUpdates calling synch worker on message ');

synchEntityData
(
synchEntityData(
payload,
entity,
summit,
eventsData,
newAllIDXEvents,
newAllSpeakers,
newAllIDXSpeakers
)
}
);
};
}

/**
Expand Down