fix: Update zarr>=3, keep numpy<2 pin, and test notebooks#242
Open
Safwannn89 wants to merge 1 commit intoOSOceanAcoustics:mainfrom
Open
fix: Update zarr>=3, keep numpy<2 pin, and test notebooks#242Safwannn89 wants to merge 1 commit intoOSOceanAcoustics:mainfrom
Safwannn89 wants to merge 1 commit intoOSOceanAcoustics:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 69.27% 69.27%
=======================================
Files 11 11
Lines 690 690
=======================================
Hits 478 478
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @LOCEANlloydizard! I went ahead and updated to zarr>=3 and tested the notebooks, but ran into a few interesting things along the way. I initially tried unpinning NumPy completely, but since NumPy 2.x causes netCDF4 to crash with a dtype size error, I put the numpy<2 pin back in for now so the notebooks actually run. I also noticed that the Zarr 3 update seems to break ep.commongrid.compute_MVBS() in get_ship_data; I dug into the traceback and found it failing deep in flox when it tries to index a PyArrow ChunkedArray (throwing a TypeError about integer scalar arrays). The try/except block swallows it so the cell doesn't completely halt, but I want to flag that upstream bug for you. Lastly, the GitHub Actions failed on the Python 3.10 runner because Zarr 3 officially requires Python >=3.11. Since the tests passed perfectly on 3.11 and 3.12, we might just need to drop 3.10 from the workflow entirely. The updated requirements.txt is in this PR, so just let me know how you'd like to handle the CI matrix!