[16.0][FIX] project_task_project_required: do not delete project_id field default attrs in view_task_form2 view#1726
Open
Tisho99 wants to merge 1 commit into
Conversation
…efault attrs in view_task_form2 view
OCA-git-bot
added
mod:project_task_project_required
Tisho99
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue in this module.
The modified view overrides the attributes of the following field, removing the invisible attribute and causing the field to be duplicated in some cases.
This change still overrides the attributes, but now preserves the existing ones.
I also considered fixing this by using the add, remove, and separator attributes of the attribute tag to avoid overriding the attrs dictionary. However, matching dictionaries with that approach causes some issues.