Add a method to get total value of a contract line#1429
Open
baimont wants to merge 1 commit into
Open
Conversation
baimont
force-pushed
the
bai_contract_total_amount
branch
from
dc907d3 to
090aeca
Compare
Contributor
Author
|
@qgroulard @sbejaoui take a look please :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for adding this method to the base
contractmodule rather than to extension modules is extensibility: many modules customize contract behavior (custom quantity rules, variable pricing, etc.).By overriding
_get_contract_line_total_value()in those modules, they can influence the total value used downstream by any module that needs it — such as some modules we'll announce soon with @sbidoul — without creating unwanted cross-dependencies.