[16.0][IMP] subscription_oca: Support section/note subscription lines, add search filters#1419
Open
ivilata wants to merge 1 commit into
Open
[16.0][IMP] subscription_oca: Support section/note subscription lines, add search filters#1419ivilata wants to merge 1 commit into
ivilata wants to merge 1 commit into
Conversation
ivilata
changed the title
ivilata
added a commit
to ivilata/oca--contract
that referenced
this pull request
Apr 28, 2026
That version avoids `ModuleNotFoundError: No module named 'pkg_resources'` when running the Git pre-commit hook, which causes an error in all CI runs. See OCA#1402 or OCA#1419 for examples of 16.0 PRs failing because of this error, and acsone/setuptools-odoo#126 for some context on the error (caused by the recent removal on `pkg_resources` from `setuptools`) and how `setuptools-odoo` v3.3.2 fixes it. Pre-commit hook configurations for 17.0 and 18.0 don't seem to depend on `setuptools-odoo`. Similar changes may be ported back to 16.0 as a more stable fix, but the current one is a very simple, low-impact fix that may help unlock PRs right now.
Author
ivilata
force-pushed
the
16.0-imp-subscription_oca-comments-filters
branch
from
1b70064 to
b483c71
Compare
…ction/note support and added filters [IMP] subscription_oca: Very minor fixes to Pol's original changes
ivilata
force-pushed
the
16.0-imp-subscription_oca-comments-filters
branch
from
b483c71 to
1856b51
Compare
Author
|
@pedrobaeza, @etobella would you mind reviewing this PR? IMHO it brings some useful enhancements without much distress. Thanks! 🙂 |
Member
|
I use and prefer |
Author
|
@pedrobaeza: Hehe, ok, I just saw that you were active lately with mergin some repo PRs. I also see that @rousseldenis merged/reviewed some PRs related with |
Author
|
Also @HaraldPanten and @PauMAVA, you may be interested in reviewing these. Thanks! 🙂 |
|
@ivilata We used this module a few years ago but, as Pedro suggested, we eventually moved all our projects to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves subscriptions in the following ways:
It is a re-take of @PolComas' #1287 with very minor fixes.