[19.0][MIG] subscription_oca: Migration to 19.0 by stferraro · Pull Request #1393 · OCA/contract

stferraro · 2026-02-23T20:57:39Z

“Applied the requested test corrections as per review.”

yvaucher · 2026-02-24T13:18:03Z

/ocabot migration subscription_oca

yvaucher · 2026-02-24T13:29:32Z

@stferraro The commit history looks really weird, you need to keep the history of the module

I expect to see those commits:

https://github.com/OCA/contract/commits/17.0/subscription_oca

(translation commits can be merged)

Please find here the whole instructions for module migration: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

yvaucher

Commit history is broken

stferraro · 2026-02-24T13:52:43Z

@yvaucher ok close this pr and open new with this change for migrate this module

yvaucher · 2026-02-24T13:55:52Z

You can push force on this one to fix it, no need to close it.

Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Currently translated at 92.6% (151 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/fi/

stferraro · 2026-05-05T16:17:45Z

hi, @pedrobaeza please check this pr and approve !

pedrobaeza · 2026-05-05T16:21:07Z

Sorry, nop, I don't use it, and I don't want to either, because for me, the best one is contract for this task.

yvaucher · 2026-05-05T17:28:07Z

Final code looks good, I have just a doubt on the git history, did you integrate an additional fix for #1320min the migration commit? If so could you separate it in an other commit? It would help for backport.

stferraro · 2026-05-05T21:20:49Z

Hi!, @yvaucher
The migration and the fix for bug #1320 have been split into two separate commits to keep the history clean and facilitate backporting.
You can proceed with the review/approval.
Thanks for your feedback!

yvaucher

Code LGTM

Just rename your Migraçion commit to be in English.

…changing quantity

yvaucher · 2026-05-06T12:34:05Z

@thib-d it requires a second approval, if you tested it and approve this PR we can merge it.

stferraro · 2026-05-06T12:35:20Z

Hi, @CristianoMafraJunior please check this PR and approve

thib-d · 2026-05-07T22:57:53Z

#1428 @stferraro I saw this, is it a bug or a misunderstanding ?
Are we suppose to be able to create subscription via the webshop ?

stferraro · 2026-05-07T23:26:03Z

Hi!, @thib-d , i resolve the bug (#1428), for your second question based on the module documentation, this functionality is out of scope for subscription_oca.
The documented scope covers:

Subscription management from the backend (create/manage subscriptions, start date, recurring invoicing via cron).
Subscription creation from Sales Orders using subscribable products and subscription templates.
It does not document or implement direct subscription creation from webshop/eCommerce flows, so that expectation would belong to another website-specific addon/integration.

…ew subscriptions (OCA#1428 bug)

stferraro · 2026-05-08T00:10:44Z

@thib-d please code review and functional test please !

stferraro · 2026-05-08T00:12:11Z

Hi, @Tisho99 please check this pr

thib-d · 2026-05-09T13:33:34Z

Didn't saw saw any bug :)

Karla-Villegas

Approved!!

OCA-git-bot · 2026-05-14T20:00:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot added this to the 19.0 milestone Feb 24, 2026

OCA-git-bot mentioned this pull request Feb 24, 2026

Migration to version 19.0 #1310

Open

27 tasks

yvaucher changed the title ~~19.0 mig subscription oca~~ [19.0][MIG] subscription_oca Feb 24, 2026

yvaucher requested changes Feb 24, 2026

View reviewed changes

carlos-domatix and others added 22 commits March 5, 2026 19:11

[15.0][ADD] subscription_oca

ab5f056

[IMP] subscription_oca: tests

7f38702

[IMP] subscription_oca: refactoring

9aeb865

Added translation using Weblate (Spanish)

bdc0fdc

[MIG] subscription_oca: Migration to 16.0

77a7337

[IMP] subscription_oca: tests

56a589c

[IMP] subscription_oca: tests adjustments

487ff5d

[UPD] Update subscription_oca.pot

e7bb2f0

[BOT] post-merge updates

064324d

Added translation using Weblate (French)

66bf948

Added translation using Weblate (Dutch)

8f3a13c

Translated using Weblate (Dutch)

4d4ca34

Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/

Added translation using Weblate (Italian)

7b72669

[IMP] subscription_oca: pre-commit auto fixes

22c3287

[MIG] subscription_oca: Migration to 17.0

faebf2b

[UPD] Update subscription_oca.pot

ccdd24e

[BOT] post-merge updates

a2b491e

Update translation files

981f00c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/

Translated using Weblate (Italian)

41cc81d

Currently translated at 100.0% (163 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/it/

Added translation using Weblate (Finnish)

62e88b8

Translated using Weblate (Finnish)

ff955ac

Currently translated at 92.6% (151 of 163 strings) Translation: contract-17.0/contract-17.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-17-0/contract-17-0-subscription_oca/fi/

Added translation using Weblate (Turkish)

a902a18

stferraro changed the title ~~[19.0][MIG] subscription_oca~~ [19.0][MIG] subscription_oca: Migration to 19.0 May 5, 2026

stferraro force-pushed the 19.0-mig-subscription_oca branch from d46db7c to 00b7f8b Compare May 5, 2026 16:16

OCA-git-bot added series:19.0 mod:subscription_oca Module subscription_oca labels May 5, 2026

stferraro force-pushed the 19.0-mig-subscription_oca branch 2 times, most recently from 50396e2 to be39aba Compare May 5, 2026 21:14

yvaucher approved these changes May 6, 2026

View reviewed changes

stferraro added 2 commits May 6, 2026 08:00

[MIG] subscription_oca: Migration to 19.0

c93b3f9

[FIX] subscription_oca: bug OCA#1320 - preserve manual discount when …

8dc41de

…changing quantity

stferraro force-pushed the 19.0-mig-subscription_oca branch from be39aba to 8dc41de Compare May 6, 2026 12:03

stferraro requested a review from yvaucher May 6, 2026 12:03

yvaucher approved these changes May 6, 2026

View reviewed changes

thib-d mentioned this pull request May 7, 2026

[19.0][BUG] subscription_oca: next invoice date ignores future subscription start date #1428

Closed

[FIX][MIG] subscription_oca: respect start date for next invoice on n…

5cc5f7c

…ew subscriptions (OCA#1428 bug)

stferraro requested a review from yvaucher May 7, 2026 23:29

Karla-Villegas approved these changes May 14, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels May 14, 2026

Uh oh!

Conversation

stferraro commented Feb 23, 2026

Uh oh!

yvaucher commented Feb 24, 2026

Uh oh!

yvaucher commented Feb 24, 2026

Uh oh!

yvaucher left a comment

Choose a reason for hiding this comment

Uh oh!

stferraro commented Feb 24, 2026

Uh oh!

yvaucher commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stferraro commented May 5, 2026

Uh oh!

pedrobaeza commented May 5, 2026

Uh oh!

yvaucher commented May 5, 2026

Uh oh!

stferraro commented May 5, 2026

Uh oh!

yvaucher left a comment

Choose a reason for hiding this comment

Uh oh!

yvaucher commented May 6, 2026

Uh oh!

stferraro commented May 6, 2026

Uh oh!

thib-d commented May 7, 2026

Uh oh!

stferraro commented May 7, 2026

Uh oh!

stferraro commented May 8, 2026

Uh oh!

stferraro commented May 8, 2026

Uh oh!

thib-d commented May 9, 2026

Uh oh!

Karla-Villegas left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

yvaucher commented Feb 24, 2026 •

edited

Loading