feat(flakes): `github:DeterminateSystems/*` by Malix-Labs · Pull Request #1016 · NixOS/nixos-search

Malix-Labs · 2025-09-23T17:07:57Z

https://github.com/orgs/DeterminateSystems/repositories?q=sort:stars+archived:false

Malix-Labs · 2025-09-28T00:20:50Z

Should I split it into multiple pull requests instead?

raboof · 2025-09-28T15:38:00Z

I'm fine with it being a single PR, but CI is currently failing

Malix-Labs · 2025-09-28T15:40:22Z

Yes true, which is also weird as it succeeded once

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

raboof · 2026-01-17T09:55:30Z

I want to start cleaning up some old pull request, could you either fix or close yours?

Malix-Labs · 2026-01-17T13:58:04Z

By fixing do you mean rebase and reorder ?

raboof · 2026-01-17T14:22:37Z

the ordering looks good to me but CI is failing:

command 'nix eval --json --no-allow-import-from-derivation --no-write-lock-file -f '/nix/store/qs1mwb04ia7jnd3k61fk52w0n9qc20l9-flake-info/assets/commands/flake_info.nix' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixpkgs-unstable.tar.gz --override-flake input-flake github:DeterminateSystems/dhcpv6macd --argstr flake github:DeterminateSystems/dhcpv6macd all' failed: exit status: 1
      stdout:
      
      stderr:
      copying path '/nix/store/cd6v80pj9h7r2prxx9a71y92zq88p1xx-source' from 'https://cache.nixos.org/'...
      error:
             … while evaluating list element at index 2
               at /nix/store/qs1mwb04ia7jnd3k61fk52w0n9qc20l9-flake-info/assets/commands/flake_info.nix:379:3:
                378|   options = readFlakeOptions;
                379|   all = packages ++ apps ++ options;
                   |   ^
                380|
      
             … while evaluating attribute 'description'
               at /nix/store/b9gsbkv9ks9ajafrrpnsl5ksk4rxwdj7-source/lib/options.nix:580:11:
                579|           inherit name;
                580|           description = opt.description or null;
                   |           ^
                581|           declarations = filter (x: x != unknownModule) opt.declarations;
      
             … while evaluating the attribute 'description'
               at /nix/store/qsas1a4f979w3dlkhrknmk0ypdvysi2b-source/flake.nix:114:19:
                113|                   type = lib.types.str;
                114|                   description = lib.mdDoc ''
                   |                   ^
                115|                     The IPv6 address to start with when issuing IP addresses.
      
             error: attribute 'mdDoc' missing
             at /nix/store/qsas1a4f979w3dlkhrknmk0ypdvysi2b-source/flake.nix:114:33:
                113|                   type = lib.types.str;
                114|                   description = lib.mdDoc ''
                   |                                 ^
                115|                     The IPv6 address to start with when issuing IP addresses.

(and some more failures)

Malix-Labs · 2026-01-17T15:33:17Z

Okay, will fix before the end of the weekend

Malix-Labs · 2026-01-17T20:48:21Z

@raboof the check still fails after 68358c2

Malix-Labs · 2026-01-18T17:37:03Z

@raboof it's the same error in https://github.com/NixOS/nixos-search/actions/runs/21092360390/job/60665340663?pr=1015

Since #1015 is very small and has basically nothing to error about, I think both errors are unrelated to my PRs

raboof · 2026-02-12T08:45:15Z

@raboof it's the same error in https://github.com/NixOS/nixos-search/actions/runs/21092360390/job/60665340663?pr=1015

Since #1015 is very small and has basically nothing to error about

I now see two errors:

2026-02-12T00:37:24.3894791Z     
2026-02-12T00:37:24.3895177Z            … in the condition of the assert statement
2026-02-12T00:37:24.3895766Z              at «nix-internal»/call-flake.nix:79:13:
2026-02-12T00:37:24.3896255Z                78|           if node.flake or true then
2026-02-12T00:37:24.3896781Z                79|             assert builtins.isFunction flake.outputs;
2026-02-12T00:37:24.3897258Z                  |             ^
2026-02-12T00:37:24.3897586Z                80|             result
2026-02-12T00:37:24.3897927Z     
2026-02-12T00:37:24.3898287Z            … while calling the 'isFunction' builtin
2026-02-12T00:37:24.3898842Z              at «nix-internal»/call-flake.nix:79:20:
2026-02-12T00:37:24.3899490Z                78|           if node.flake or true then
2026-02-12T00:37:24.3900014Z                79|             assert builtins.isFunction flake.outputs;
2026-02-12T00:37:24.3900503Z                  |                    ^
2026-02-12T00:37:24.3900893Z                80|             result
2026-02-12T00:37:24.3901246Z     
2026-02-12T00:37:24.3901622Z            … while calling the 'import' builtin
2026-02-12T00:37:24.3902194Z              at «nix-internal»/call-flake.nix:54:19:
2026-02-12T00:37:24.3902623Z                53|
2026-02-12T00:37:24.3902999Z                54|           flake = import (outPath + "/flake.nix");
2026-02-12T00:37:24.3903480Z                  |                   ^
2026-02-12T00:37:24.3903839Z                55|
2026-02-12T00:37:24.3904098Z     
2026-02-12T00:37:24.3904483Z            … while realising the context of a path
2026-02-12T00:37:24.3904905Z     
2026-02-12T00:37:24.3905272Z            … while calling the 'fetchTree' builtin
2026-02-12T00:37:24.3905874Z              at «nix-internal»/call-flake.nix:48:15:
2026-02-12T00:37:24.3906389Z                47|               # FIXME: remove obsolete node.info.
2026-02-12T00:37:24.3907092Z                48|               fetchTree (node.info or {} // removeAttrs node.locked ["dir"]);
2026-02-12T00:37:24.3907715Z                  |               ^
2026-02-12T00:37:24.3908064Z                49|
2026-02-12T00:37:24.3908327Z     
2026-02-12T00:37:24.3910232Z            … while fetching the input 'https://api.flakehub.com/f/pinned/DeterminateSystems/secure/0.888552.261/019a73d2-a43f-7e74-9e6a-6c8b9acc81eb/source.tar.gz?narHash=sha256-c%2BmaK634KQ2FM3C0LBzXh5xT8blrMBh%2BLzMEJDULHns%3D'
2026-02-12T00:37:24.3911831Z     
2026-02-12T00:37:24.3913298Z            error: Failed to open archive (Source threw exception: error: unable to download 'https://api.flakehub.com/f/pinned/DeterminateSystems/secure/0.888552.261/019a73d2-a43f-7e74-9e6a-6c8b9acc81eb/source.tar.gz': HTTP error 404
2026-02-12T00:37:24.3915089Z     
2026-02-12T00:37:24.3915510Z                   response body:
2026-02-12T00:37:24.3915876Z     
2026-02-12T00:37:24.3916264Z                   Flake `DeterminateSystems/secure/0.888552.261` not found.
2026-02-12T00:37:24.3916810Z     
2026-02-12T00:37:24.3917619Z                   Either it doesn't exist (did you make a typo?), or you do not have adequate permissions to see it (are you logged in to FlakeHub?).
2026-02-12T00:37:24.3918564Z     
2026-02-12T00:37:24.3918819Z                   First, try running
2026-02-12T00:37:24.3919180Z     
2026-02-12T00:37:24.3919622Z                     determinate-nixd auth login
2026-02-12T00:37:24.3920014Z     
2026-02-12T00:37:24.3920310Z                   to log in to FlakeHub and try again.)
2026-02-12T00:37:24.3920718Z

and

2026-02-12T00:37:25.7000055Z            error: Failed to open archive (Source threw exception: error: unable to download 'https://api.flakehub.com/f/pinned/DeterminateSystems/secure/0.904649.313/019b4714-003c-7b50-a3aa-ffc368440845/source.tar.gz': HTTP error 404
2026-02-12T00:37:25.7000924Z     
2026-02-12T00:37:25.7001079Z                   response body:
2026-02-12T00:37:25.7001270Z     
2026-02-12T00:37:25.7001492Z                   Flake `DeterminateSystems/secure/0.904649.313` not found.
2026-02-12T00:37:25.7001784Z     
2026-02-12T00:37:25.7002226Z                   Either it doesn't exist (did you make a typo?), or you do not have adequate permissions to see it (are you logged in to FlakeHub?).
2026-02-12T00:37:25.7002730Z     
2026-02-12T00:37:25.7002875Z                   First, try running
2026-02-12T00:37:25.7003079Z     
2026-02-12T00:37:25.7003247Z                           determinate-nixd auth login
2026-02-12T00:37:25.7003487Z     
2026-02-12T00:37:25.7003655Z                   to log in to FlakeHub and try again.)
2026-02-12T00:37:25.7003904Z

Both of these seem different from #1015 (which seems to be #902).

I think both errors are unrelated to my PRs

Still, your PR is blocked by the error. I cannot merge PRs that are failing. You'll have to either diagnose and fix the issue, or remove the failing flakes from the PR (perhaps comment them out with a reference to the issue).

Malix-Labs · 2026-02-14T19:52:33Z

#1016 (comment) by @raboof :

Still, your PR is blocked by the error. I cannot merge PRs that are failing

The problem is that this PR is failing for extraneous reasons;
Because the CI flake checks is incorrectly implemented (see #1027 and #1144)

You'll have to either diagnose and fix the issue, or remove the failing flakes from the PR (perhaps comment them out with a reference to the issue).

The reason this PR is failing is because of #1027 and #1144;
The reason the other flakes are failing might be because of #1143

So we have 3 options:

Hold PRs that are introducing valid flakes until fix(ci): Flakes Check - Decoupling Patches and Batch #1027 and fix(flakes): pinning locking #1144 is fixed
Merge PRs that are introducing valid flakes even though fix(ci): Flakes Check - Decoupling Patches and Batch #1027 and fix(flakes): pinning locking #1144 is not fixed
Make extraneous changes (such as feat(flake-info): fallbacks #1143) to PRs introducing valid flakes to comply with the incorrectly implemented CI (see fix(ci): Flakes Check - Decoupling Patches and Batch #1027 and fix(flakes): pinning locking #1144)

I think option 1 is the most valid, 2 is if we are in a rush (which we are not) and option 3 is plainly incorrect

raboof · 2026-02-15T09:35:27Z

#1016 (comment) by @raboof :

Still, your PR is blocked by the error. I cannot merge PRs that are failing

The problem is that this PR is failing for extraneous reasons; Because the CI flake checks is incorrectly implemented (see #1027 and #1144)

You'll have to either diagnose and fix the issue, or remove the failing flakes from the PR (perhaps comment them out with a reference to the issue).

The reason this PR is failing is because of #1027 and #1144; The reason the other flakes are failing might be because of #1143

Please look at the failure logs yourself. The failures are in github:DeterminateSystems/fh and github:DeterminateSystems/flake-checker, which are introduced in this PR. This has nothing to do with #1027 and #1144 .

Malix-Labs · 2026-02-15T12:55:31Z

I mixed PR messages, yes

I think even the DeterminateSystems flakes breaking might be caused because of issues raised in #1143 as well

I will try to debug them

raboof · 2026-04-08T07:36:54Z

CI is still failing, are you still planning to look into this? Otherwise I think we should close this (and similar PRs)

Malix-Labs · 2026-04-08T12:56:22Z

@raboof this PR is failing because of flakes that aren't touched by this PR

All the github:DeterminateSystems/* flakes pass

https://github.com/NixOS/nixos-search/actions/runs/24127260029/job/70394803575?pr=1016

We are back to #1016 (comment)

raboof · 2026-04-08T13:20:20Z

@raboof this PR is failing because of flakes that aren't touched by this PR

All the github:DeterminateSystems/* flakes pass

On the commit right before my comment, https://github.com/NixOS/nixos-search/actions/runs/24127260029/job/70394803575, this PR was still failing on github:DeterminateSystems/fh and github:DeterminateSystems/flake-checker. Great that these are now fixed!

https://github.com/NixOS/nixos-search/actions/runs/24127260029/job/70394803575?pr=1016

We are back to #1016 (comment)

Yeah, that's my bad, I merged #1171 without noticing that it hadn't tested the flakes. That's now reverted again with #1172 though - I'll rebase this branch (though it might be something else, #1175).

Malix-Labs · 2026-04-08T13:31:45Z

On the commit right before my comment, NixOS/nixos-search/actions/runs/24127260029/job/70394803575, this PR was still failing on github:DeterminateSystems/fh and github:DeterminateSystems/flake-checker. Great that these are now fixed!

Yep dw I've noticed

It's really tiresome that checks CI is nondeterministic, I really should work on #1141

raboof · 2026-04-08T14:57:13Z

(failure is now #1175)

Malix-Labs · 2026-04-08T15:01:17Z

I guess this PR can be merged, then

Malix-Labs marked this pull request as draft September 23, 2025 17:10

Malix-Labs marked this pull request as ready for review September 23, 2025 17:10

Malix-Labs changed the title ~~feat: flake github:DeterminateSystems/fh~~ feat: flake github:DeterminateSystems/* Sep 23, 2025

Malix-Labs changed the title feat: flake github:DeterminateSystems/* feat(flakes): github:DeterminateSystems/* Sep 29, 2025

Malix-Labs marked this pull request as draft October 6, 2025 18:56

Malix-Labs force-pushed the patch-5 branch 2 times, most recently from 6fc23f2 to a909d6f Compare October 9, 2025 19:46

Malix-Labs marked this pull request as ready for review October 9, 2025 19:48

Malix-Labs marked this pull request as draft October 12, 2025 00:15

Malix-Labs force-pushed the patch-5 branch from f7c5154 to bb53306 Compare October 12, 2025 00:29

Malix-Labs marked this pull request as ready for review October 12, 2025 00:30

Copilot AI review requested due to automatic review settings January 2, 2026 12:31

Copilot AI reviewed Jan 2, 2026

View reviewed changes

Malix-Labs force-pushed the patch-5 branch from 1243f08 to 696d160 Compare January 17, 2026 18:18

Malix-Labs commented Jan 17, 2026

View reviewed changes

Comment thread flakes/manual.toml Outdated

miniBill added the flake PRs that add/update flakes label Feb 11, 2026

Malix-Labs force-pushed the patch-5 branch from 68358c2 to 16a2519 Compare February 12, 2026 00:29

Malix-Labs force-pushed the patch-5 branch from 16a2519 to 420ffb3 Compare February 18, 2026 01:23

KiaraGrouwstra approved these changes Mar 26, 2026

View reviewed changes

Malix-Labs added 18 commits April 8, 2026 11:04

feat(flakes): github:DeterminateSystems/bonk

5e5bdc8

feat(flakes): github:DeterminateSystems/cpiotools

d80a49e

feat(flakes): github:DeterminateSystems/determinate

c77a6b4

feat(flakes): github:DeterminateSystems/dhcpv6macd

cc3144b

feat(flakes): github:DeterminateSystems/fh

a8cdd99

feat(flakes): github:DeterminateSystems/flake-checker

a3f3041

feat(flakes): github:DeterminateSystems/flake-iter

9eca8a2

feat(flakes): github:DeterminateSystems/flake-schemas

a4ce9f8

feat(flakes): github:DeterminateSystems/flake-templates

ebf7f5c

feat(flakes): github:DeterminateSystems/magic-nix-cache

f0b72c7

feat(flakes): github:DeterminateSystems/nix-config-parser

56fb1cd

feat(flakes): github:DeterminateSystems/nix-installer

d396333

feat(flakes): github:DeterminateSystems/nix-netboot-serve

fecf524

feat(flakes): github:DeterminateSystems/nix-src

0f8e7d7

feat(flakes): github:DeterminateSystems/nixos-vault-service

601d3fc

feat(flakes): github:DeterminateSystems/update-flake-lock

16a03d9

feat(flakes): github:DeterminateSystems/zpool-auto-expand-partitions

2147973

fix(flakes): comment github:DeterminateSystems/dhcpv6macd

135bcde

Malix-Labs force-pushed the patch-5 branch from 420ffb3 to 135bcde Compare April 8, 2026 09:04

Merge branch 'main' into patch-5

fb2ce55

Merge branch 'main' into patch-5

c1d4419

Uh oh!

Conversation

Malix-Labs commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Malix-Labs commented Sep 28, 2025

Uh oh!

raboof commented Sep 28, 2025

Uh oh!

Malix-Labs commented Sep 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

raboof commented Jan 17, 2026

Uh oh!

Malix-Labs commented Jan 17, 2026

Uh oh!

raboof commented Jan 17, 2026

Uh oh!

Malix-Labs commented Jan 17, 2026

Uh oh!

Uh oh!

Malix-Labs commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Malix-Labs commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raboof commented Feb 12, 2026

Uh oh!

Malix-Labs commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raboof commented Feb 15, 2026

Uh oh!

Malix-Labs commented Feb 15, 2026

Uh oh!

raboof commented Apr 8, 2026

Uh oh!

Malix-Labs commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raboof commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Malix-Labs commented Apr 8, 2026

Uh oh!

raboof commented Apr 8, 2026

Uh oh!

Malix-Labs commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Malix-Labs commented Sep 23, 2025 •

edited

Loading

Malix-Labs commented Jan 17, 2026 •

edited

Loading

Malix-Labs commented Jan 18, 2026 •

edited

Loading

Malix-Labs commented Feb 14, 2026 •

edited

Loading

Malix-Labs commented Apr 8, 2026 •

edited

Loading

raboof commented Apr 8, 2026 •

edited

Loading