Skip to content

fix: add favicon.ico support#476

Closed
GulshanJha00 wants to merge 8 commits intoNextCommunity:mainfrom
GulshanJha00:fix-favicon-404
Closed

fix: add favicon.ico support#476
GulshanJha00 wants to merge 8 commits intoNextCommunity:mainfrom
GulshanJha00:fix-favicon-404

Conversation

@GulshanJha00
Copy link
Copy Markdown
Contributor

Fixes #134

Added favicon.ico support by:

  • adding a root favicon.ico file
  • configuring Eleventy passthrough copy
  • linking the favicon in the document head

This resolves the 404 issue for /favicon.ico.
Screenshot 2026-05-03 at 23 58 09

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds favicon support by configuring the Eleventy passthrough and adding the icon link to the main template. It also includes a layout adjustment for the developer list. Feedback suggests removing the hardcoded versioning from the favicon link and using standard Tailwind spacing classes instead of arbitrary values for the layout change, which should ideally be handled in a separate commit.

Comment thread src/index.njk Outdated
Comment thread src/index.njk
<div class="p-8">
<div class="flex justify-between items-start gap-4">
<div class="flex-1">
<div class="flex-1 min-w-[150px]">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This layout change (min-w-[150px]) appears to be unrelated to the favicon support described in the PR title and description. To maintain code quality and follow the principle of atomic commits, unrelated changes should be handled in a separate pull request. Additionally, consider using standard Tailwind spacing classes (e.g., min-w-36 or min-w-40) instead of arbitrary values to ensure consistency with the design system.

            <div class="flex-1">
References
  1. Adhere to the project's existing CSS framework (Tailwind CSS) and its conventions, such as using standard theme values for spacing and sizing instead of arbitrary values.

@github-project-automation github-project-automation Bot moved this to Done in Next May 3, 2026
@GulshanJha00 GulshanJha00 deleted the fix-favicon-404 branch May 3, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

404 not found for favicon.ico

1 participant