Issue #264: Restricting python version and removing pkg_resources by EmilyPascua · Pull Request #265 · NASA-AMMOS/AIT-GUI

EmilyPascua · 2026-03-26T19:55:41Z

Changes primarily to:

Restrict python version to match with changes of ait-core and remove pkg_resources which has been deprecated.
Tox lint test was failing - had to make some updates to a few files to fix them.
Base python version is now 3.11

sonarqubecloud · 2026-04-23T18:03:34Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

EmilyPascua · 2026-04-23T18:04:27Z

@nttoole This wasn't introduced in this PR. But SonarQube picked it up so I'm adding changes as requested.

lint run-test: commands[0] | python -m pre_commit run --color=always --all
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
Check for merge conflicts................................................Passed
Debug Statements (Python)................................................Passed
Reorder python imports...............................(no files to check)Skipped
mypy.....................................................................Passed
black................................................(no files to check)Skipped
flake8...................................................................Passed
_________________________________________________________________________________________ summary __________________________________________________________________________________________
  docs: commands succeeded
  lint: commands succeeded
  congratulations :)

nttoole · 2026-05-04T19:00:06Z

                       bytes: [2, 3],
                       name: "Voltage_B",
-                       desc: "Voltage B as a 14-bit DN. Conversion to engineering units is TBD."
+                       desc: "Voltage B as a 14-bit DN. Conversion to


I assume a line-width rule violation caused the edit, but I think it would be better to preserve the JSON as it was

nttoole · 2026-05-04T19:00:17Z

                       bytes: [4, 5],
                       name: "Voltage_C",
-                       desc: "Voltage C as a 14-bit DN. Conversion to engineering units is TBD."
+                       desc: "Voltage C as a 14-bit DN. Conversion to


Done. - I added a noqa so the flake linter just ignore this.

nttoole · 2026-05-04T22:47:41Z

@@ -0,0 +1 @@
+3.11


Just checking if this should include '3.10' as well?

nttoole · 2026-05-04T22:50:32Z

    - none
 python:
-    version: "3.8"
+    version: "3.11"


This looks fine here, tho I noted that AIT-Core's version of this file still has '3.8'

Edit: Ah! Need to update AIT-DSN and AIT-Core to be consistent.

nttoole · 2026-05-04T22:55:57Z

@@ -1,26 +1,26 @@
 [tox]
+allowlist_externals = poetry


Similar to readthedocs comment, the contents of this tox.ini seems a bit different from AIT-Core's (Core lists py 310 and 311, mix of white/allow list_externals, etc)
Not sure if needed since this is a plugin, but wanted to check. Thanks

@nttoole The tox tests just runs differently for AIT-GUI versus what we have for AIT-Core. In AIT-Core, we have Github actions configured (hence why those are supplied in the environment) and the tox tests actually run dynamically for multiple python versions. For AIT-GUI we have it set to the BasePython version of 3.11 (prior was 3.10) - Let me know if we should remain with Python 3.10.

Maybe an item for the future to make these tests more dynamic so it's running both 11 and 10.

nttoole

@EmilyPascua I am also seeing what looks like a couple of security-related fixes (re paths as args).
Could these please be split out to a separate PR - since we may need to specifically reference them in future security documentation? Thx

sonarqubecloud · 2026-05-05T22:53:04Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

EmilyPascua · 2026-05-05T22:56:51Z

Ready for review @nttoole !

EmilyPascua · 2026-05-05T22:53:05Z


 [tool.poetry.dependencies]
 python              = ">= 3.10 < 3.12"
-ait-core            = { path = "../AIT-Core", develop = true }


Removing dev.

EmilyPascua · 2026-05-05T22:55:52Z

@@ -0,0 +1 @@
+3.11


EmilyPascua · 2026-05-05T22:56:23Z

                       bytes: [4, 5],
                       name: "Voltage_C",
-                       desc: "Voltage C as a 14-bit DN. Conversion to engineering units is TBD."
+                       desc: "Voltage C as a 14-bit DN. Conversion to


Done. - I added a noqa so the flake linter just ignore this.

EmilyPascua · 2026-05-05T22:56:28Z

                       bytes: [2, 3],
                       name: "Voltage_B",
-                       desc: "Voltage B as a 14-bit DN. Conversion to engineering units is TBD."
+                       desc: "Voltage B as a 14-bit DN. Conversion to


EmilyPascua · 2026-05-05T22:57:54Z

                       name: "Voltage_B",
-                       desc: "Voltage B as a 14-bit DN. Conversion to
-                             engineering units is TBD."
+                       desc: "Voltage B as a 14-bit DN. Conversion to engineering units is TBD." # noqa: B950


Adding noqa: B950 so linter ignores.

jl-0 and others added 4 commits February 11, 2026 13:16

Updates to support python 3.12 - AWS Transform

bd0e3ca

Issue-264: Restricting python version and removing pkg_resources

60e1152

Issue #264: Consistency with python version req

91d922b

Issue #264: Pick up the config files properly

adde2f7

EmilyPascua requested a review from nttoole March 26, 2026 19:55

EmilyPascua requested review from a team as code owners March 26, 2026 19:55

Issue #264: Fixing sonarqube check - safe handling with path

dbd4ec2

nttoole reviewed May 4, 2026

View reviewed changes

nttoole reviewed May 5, 2026

View reviewed changes

epascua added 2 commits May 5, 2026 15:48

Issue #264: Review changes

f7fb006

Merge branch 'issue-264' of github.com:NASA-AMMOS/AIT-GUI into issue-264

207ed80

EmilyPascua requested a review from nttoole May 5, 2026 22:56

EmilyPascua commented May 5, 2026

View reviewed changes

EmilyPascua mentioned this pull request May 5, 2026

Issue #264: Adding sonarqube changes #266

Open

Conversation

EmilyPascua commented Mar 26, 2026

Uh oh!

sonarqubecloud Bot commented Apr 23, 2026

Quality Gate passed

Uh oh!

EmilyPascua commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EmilyPascua May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EmilyPascua May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nttoole left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 5, 2026

Quality Gate passed

Uh oh!

EmilyPascua commented May 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EmilyPascua commented Apr 23, 2026 •

edited

Loading

EmilyPascua May 5, 2026 •

edited

Loading

EmilyPascua May 5, 2026 •

edited

Loading