Skip to content

Guidance hours to internal#816

Open
PetterTjeldeVaagen wants to merge 11 commits into
mainfrom
feature/guidance-hours-to-internal
Open

Guidance hours to internal#816
PetterTjeldeVaagen wants to merge 11 commits into
mainfrom
feature/guidance-hours-to-internal

Conversation

@PetterTjeldeVaagen
Copy link
Copy Markdown
Contributor

@PetterTjeldeVaagen PetterTjeldeVaagen commented May 6, 2026

Proposed changes

Added the guidance hours to the internal pages of the website

Review guidance

Deployment notes

Manually fills in the current times for guidance hours

Checklist

(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)

  • I've run makemigrations, makemessages and compilemessages
  • I've written tests that fail without these changes (if relevant/possible)
  • I've manually tested the website UI with different device layouts
    • Most common is to test with typical screen sizes for mobile (320-425 px), tablet (768 px) and desktop (1024+ px), which can easily be done with your browser's dev tools
  • I've manually tested with different users locally
    • This can be e.g. anonymous users (i.e. not being logged in), "normal" non-member users, members of different committees, and superusers
  • I've made sure that my code conforms to the code style guides
    • It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you use it as a reference guide / checklist while taking a second look at your code before opening a pull request
  • I've attempted to minimize the number of common code smells
    • See the comment for the previous checkbox
  • I've added documentation
    • E.g. comments, docstrings, or in the README
  • I've added my changes to the "Unreleased" section of the changelog, together with a link to this PR
    • Mainly the changes that are of particular interest to users and/or developers, if any
  • I've added a "Deployment notes" section above and labelled the PR with has-deployment-notes
    • ...if anything out of the ordinary should be done when deploying these changes to the server (e.g. adding/removing an environment variable, manually creating/changing some objects, running a management command, etc.)
  • I've structured my commits reasonably

@PetterTjeldeVaagen PetterTjeldeVaagen added the feature New functionality on the page label May 6, 2026
@make-bot make-bot Bot added this to web May 6, 2026
@make-bot make-bot Bot moved this to Ready for Review in web May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 86.18421% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.94%. Comparing base (787ea4b) to head (347caac).

Files with missing lines Patch % Lines
src/internal/views.py 83.96% 17 Missing ⚠️
src/internal/admin.py 84.61% 2 Missing ⚠️
src/internal/models.py 87.50% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   87.99%   87.94%   -0.06%     
==========================================
  Files         153      153              
  Lines        6249     6394     +145     
==========================================
+ Hits         5499     5623     +124     
- Misses        750      771      +21     
Files with missing lines Coverage Δ
src/internal/forms.py 86.99% <100.00%> (+1.40%) ⬆️
src/internal/urls.py 100.00% <100.00%> (ø)
src/internal/admin.py 97.29% <84.61%> (-2.71%) ⬇️
src/internal/models.py 93.33% <87.50%> (-0.57%) ⬇️
src/internal/views.py 88.17% <83.96%> (-2.60%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality on the page has-deployment-notes

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

1 participant