ci: install adduser explicitly in package-arch test step#4017
Closed
grandixximo wants to merge 1 commit into
Closed
ci: install adduser explicitly in package-arch test step#4017grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
The test step runs 'eatmydata adduser ... testrunner' but never installs adduser. It was pulled transitively via Recommends on the installed .deb files; sid no longer pulls it, so builds fail with 'eatmydata: unable to find adduser in PATH'. Add it to the existing sudo install so testrunner setup does not depend on Recommends.
3 tasks
Contributor
|
This conflicts with #3984, which is the one that should go in. You'll have to rebase when I do... |
Contributor
|
If you could be so kind, I think you need to re-apply this but to 2.9 branch. There the CI is not going to be upgraded and it fails with the same error. |
Contributor
Author
|
I was about to text you about it, just realized I need this on 2.9 for #4015 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The package-arch Test debian packages step calls
eatmydata adduser ... testrunnerto set up a non-root user for runtests, but never installs theadduserpackage. It used to work becauseadduserwas pulled transitively via Recommends of the installed.debfiles; sid no longer pulls it, so builds fail with:Surfaced today on PR #3999 (all six package-arch jobs across bookworm/trixie/sid x amd64/arm64 failed). Same failure mode reproduces on rerun, so this is not transient.
Fix
Add
adduserto the existingapt-get install sudoline so the testrunner setup does not depend on a fragile Recommends chain.Test plan