Make any coloring algorithm compatible with SMC by gdalle · Pull Request #263 · JuliaDiff/SparseMatrixColorings.jl

gdalle · 2025-10-08T12:56:36Z

Fixes #67

Context

At the moment, DI can only use algorithms from SMC, but people might want to code other coloring algorithms following the ADTypes interface, for instance our friend @SouthEndMusic who was interested in provably optimal colorings. During decompression, we will still need SMC result types, but those are deeply tied to the coloring algorithm itself (for star and acyclic colorings + their bidirectional counterparts). How do we create SMC results from a generic algorithm which outputs only a vector of colors?

Idea

Pretend we run the greedy algorithm, but force the color choices and piggyback on the rest of the procedure for constructing data structures like the StarSet and TreeSet. This enables maximum code reuse, even though it may not be optimal from a performance standpoint.
As a side bonus, this also allows us to assert correctness of the provided colorings, because our greedy procedure enforces it.

Todo

Test on a non-trivial coloring algorithm (not just ADTypes.NoColoringAlgorithm) => done with OptimalColoringAlgorithm based on a JuMP formulation, but removed from the current PR
Solve Add more coloring options -- bicoloring SciML/ADTypes.jl#69 and then integrate that
Figure out whether we can accept zero (unused) colors in the output of ADTypes.symmetric_coloring or ADTypes.bidirectional_coloring

codecov · 2025-10-08T13:02:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e77226a) to head (e4dd8c1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #263   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1955      1962    +7     
=========================================
+ Hits          1955      1962    +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

amontoison · 2025-10-12T04:35:06Z

The diff is quite big, it will be hard to review it soon.
Can you ping me when it is ready?

gdalle · 2025-10-13T10:12:11Z

@amontoison I removed the OptimalColoringAlgorithm part to simplify, this is ready to go

gdalle · 2025-10-20T08:48:40Z

Gentle bump @amontoison, this one is ready for you while #267 marinates.

PS: I deactivated the formatting test because it passes locally and I can't figure out what's wrong. More generally, JuliaFormatter seems less and less reliable, so I'll soon switch to Runic anyway.

amontoison · 2025-10-20T13:28:24Z

I will have a look today. I got a visitor last week at ANL that stayed at home. I should be less busy this week!

gdalle · 2025-10-20T13:34:13Z

Also it seems the GPU tests are failing for unrelated reasons

amontoison · 2025-10-20T13:35:59Z

Also it seems the GPU tests are failing for unrelated reasons

We ordered a new SSD for Moonshot, it is the issue.

amontoison · 2025-10-22T16:38:04Z

All tests passed, you can merge it when it is good for you 👍

@gdalle

* Bump julia-actions/julia-downgrade-compat from 1 to 2 (#258) Bumps [julia-actions/julia-downgrade-compat](https://github.com/julia-actions/julia-downgrade-compat) from 1 to 2. - [Release notes](https://github.com/julia-actions/julia-downgrade-compat/releases) - [Commits](julia-actions/julia-downgrade-compat@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/julia-downgrade-compat dependency-version: '2' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 4 to 5 (#259) * ensure `UnsupportedDecompressionError <: Exception` (#260) Not sure if there is any benefit, but I suppose the intention is for this type, as an exception type, to subtype `Exception`. * Bump peter-evans/create-or-update-comment from 4 to 5 (#261) * Bump peter-evans/find-comment from 3 to 4 (#262) Bumps [peter-evans/find-comment](https://github.com/peter-evans/find-comment) from 3 to 4. - [Release notes](https://github.com/peter-evans/find-comment/releases) - [Commits](peter-evans/find-comment@v3...v4) --- updated-dependencies: - dependency-name: peter-evans/find-comment dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Allow picking the best of several orders for GreedyColoringAlgorithm (#265) * Allow picking the best of several orders for GreedyColoringAlgorithm * Fix type params * Tuple * Better tests * Better test * Fix foc * Fix type inference inside closure * Fix seed * Test on 1.11 * Avoid duplicate remap_colors * chore: bump version to 0.4.22 (#268) * chore: fix typo in package UUID (#269) * Make any coloring algorithm compatible with SMC (#263) * Make any coloring algorithm compatible with SMC * Fix StackOverflow * Run tests on 1.11 * Start working on optimal coloring * Fix tests * Improve feasibility check * Format * Fix * Fix * Typo * Use HiGHS * Remove OptimalColoringAlgorithm * Remove test deps * Don't handle forced colors in acyclic * Run GPU CI on 1.11 too * Actually use forced colors * Format * Deactivate JuliaFormatter (can't figure out why it fails) * Optimal coloring algorithm with JuMP formulation (#271) * Add a file postprocessing.jl (#275) * Rename has_diagonal into augmented_graph (#273) * Rename has_diagonal into augmented_graph * Fix a typo in postprocessing.jl * Update src/graph.jl Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> --------- Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> * Try tests on Julia 1.12 (#276) * Bump SMC to v0.4.23 (#277) * Patch failing alloc test (#278) * Add postprocess_with_star_set! and postprocess_with_tree_set! (#279) * Bump actions/checkout from 5 to 6 (#282) Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Replace is_solved_and_feasible with assert_is_solved_and_feasible (#284) * Fix JET tests (#285) * Fix JET tests * Move JuliaFormatter to action * Fix formatting * Use diagonal_indices in the general decompress! for acyclic coloring (#287) * Enhance decompress! for bicoloring (#288) * Add a compat entry for CUDA.jl in test/Project.toml (#293) * Add nb_self_loops in AdjacencyGraph (#290) * Remove unused arguments from internal functions (#295) * Add test functions substitutable_columns and substitutable_bidirectional (#297) * Document fields of TreeSet (#296) * Fix respectful_similar with SparsityPatternCSC (#299) * Fix respectful_similar with SparsityPatternCSC * Add test * Fix format * Add test --------- Co-authored-by: Alexis Montoison <35051714+amontoison@users.noreply.github.com> * Fix coloring with empty matrix as input (#300) * Fix coloring with empty matrix as input * Update src/result.jl Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> * Add check * Fix format * Change check * Apply suggestion from @gdalle --------- Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> * test: skip failing MiniZinc tests (#305) * Fix eltype invalidation for SparsityPatternCSC (#304) SparsityPatternCSC{Ti} <: AbstractMatrix{Bool} but the custom Base.eltype method was returning Ti (the index type) instead of Bool. This caused 24,906 method invalidations when loading the package, as it invalidated the backedge from Base.eltype(::AbstractArray). Change the custom method to SparseArrays.indtype instead, since that's what the type parameter Ti actually represents. The eltype is now correctly inherited from AbstractMatrix{Bool}. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> * chore: bump version (#306) * Bump julia-actions/cache from 2 to 3 (#307) * Update repo owner to JuliaDiff org (#309) * Update repo owner * Bump version * Switch GPU CI to buildkite * Add badge * Fix buildkite badge [skip tests] (#310) * Accept AbstractSparseMatrixCSC for decompression (#298) * Accept AbstractSparseMatrixCSC for decompression * Define decompress_csc * Remove unused import of AbstractSparseMatrixCSC * Apply suggestion from @blegat * Change return statement to return nothing * Apply suggestion from @blegat * Add to docs * Apply suggestion from @gdalle Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> * Move to internals --------- Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> * Bump version (#311) * Bump codecov/codecov-action from 5 to 6 (#312) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5...v6) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: bump CUDA compat to v6 (cuSPARSE now a separate package) (#314) * chore: bump CUDA compat to v6 (cuSPARSE now a separate package) * More renaming * Format * Fix compression? * Generic compression and result * Import * No generic result * Fix ambiguity * Bump julia-actions/setup-julia from 2 to 3 (#315) Bumps [julia-actions/setup-julia](https://github.com/julia-actions/setup-julia) from 2 to 3. - [Release notes](https://github.com/julia-actions/setup-julia/releases) - [Commits](julia-actions/setup-julia@v2...v3) --- updated-dependencies: - dependency-name: julia-actions/setup-julia dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neven Sajko <4944410+nsajko@users.noreply.github.com> Co-authored-by: Guillaume Dalle <22795598+gdalle@users.noreply.github.com> Co-authored-by: Alexis Montoison <35051714+amontoison@users.noreply.github.com> Co-authored-by: Benoît Legat <benoit.legat@gmail.com> Co-authored-by: Chris Rackauckas - Beep Boop Edition <admin@chrisrackauckas.com> Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>

Make any coloring algorithm compatible with SMC

dadb75e

gdalle requested a review from amontoison October 8, 2025 12:56

Fix StackOverflow

4d01552

amontoison added the feature New feature or extension label Oct 8, 2025

gdalle added 7 commits October 8, 2025 19:45

Run tests on 1.11

48c483a

Start working on optimal coloring

6cdcbf8

Fix tests

b344414

Improve feasibility check

0e5c18b

Format

e49b468

Fix

df35321

Fix

12a246f

gdalle marked this pull request as ready for review October 10, 2025 08:20

gdalle added 2 commits October 10, 2025 10:30

Typo

a6b1ee8

Use HiGHS

4ca6507

gdalle added 2 commits October 13, 2025 11:52

Remove OptimalColoringAlgorithm

223e99f

Remove test deps

c9d3ebc

gdalle added 6 commits October 20, 2025 08:15

Merge remote-tracking branch 'origin/main' into gd/abstractcoloring

678b26b

Don't handle forced colors in acyclic

5aef3ab

Run GPU CI on 1.11 too

1522ef7

Actually use forced colors

c7c7edc

Format

b9d7d5f

Deactivate JuliaFormatter (can't figure out why it fails)

e4dd8c1

amontoison approved these changes Oct 22, 2025

View reviewed changes

gdalle merged commit b53dbf9 into main Oct 22, 2025
9 of 11 checks passed

gdalle mentioned this pull request Nov 1, 2025

Use deepcopy inside ConstantColoringAlgorithm if necessary #257

Closed

gdalle deleted the gd/abstractcoloring branch March 20, 2026 09:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make any coloring algorithm compatible with SMC#263

Make any coloring algorithm compatible with SMC#263
gdalle merged 19 commits intomainfrom
gd/abstractcoloring

gdalle commented Oct 8, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Oct 8, 2025 •

edited

Loading

Uh oh!

amontoison commented Oct 12, 2025

Uh oh!

gdalle commented Oct 13, 2025

Uh oh!

gdalle commented Oct 20, 2025

Uh oh!

amontoison commented Oct 20, 2025

Uh oh!

gdalle commented Oct 20, 2025

Uh oh!

amontoison commented Oct 20, 2025

Uh oh!

amontoison commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gdalle commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

amontoison commented Oct 12, 2025

Uh oh!

gdalle commented Oct 13, 2025

Uh oh!

gdalle commented Oct 20, 2025

Uh oh!

amontoison commented Oct 20, 2025

Uh oh!

gdalle commented Oct 20, 2025

Uh oh!

amontoison commented Oct 20, 2025

Uh oh!

amontoison commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gdalle commented Oct 8, 2025 •

edited

Loading

codecov Bot commented Oct 8, 2025 •

edited

Loading