Skip to content

UID2-1750: add explicit Lombok dependency (was relying on transitive) #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnywu merged 3 commits into from
Apr 7, 2026
Merged

UID2-1750: add explicit Lombok dependency (was relying on transitive) #615

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94bbdd8
UID2-1750: add explicit Lombok dependency to replace transitive reliance
sunnywu Apr 1, 2026
e10aaec
Remove redundant optional from lombok dependency
sunnywu Apr 7, 2026
96c75ad
Merge remote-tracking branch 'origin/main' into syw-UID2-1750-lombok-…
sunnywu Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@
<artifactId>uid2-shared</artifactId>
<version>${uid2-shared.version}</version>
</dependency>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.34</version>
<scope>provided</scope>
Copy link
Copy Markdown
Contributor

@jon8787 jon8787 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need provided and optional here because uid2-admin is a leaf project

Copy link
Copy Markdown
Contributor Author

@sunnywu sunnywu Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude said:

  • optional — agree. optional prevents the dependency from being inherited by downstream projects. Since uid2-admin is a leaf application (nothing
    depends on it as a library), it has no downstream consumers, so optional is indeed pointless here.
  • provided — disagree. provided is actually correct for lombok regardless of whether it's a leaf project. Lombok is a compile-time annotation
    processor — it generates bytecode at compile time and is not needed at runtime. Using provided keeps it out of the final fat JAR, which is the right
    behavior. This is standard practice for lombok in Maven projects.

The reviewer's "leaf project" reasoning only fully applies to optional. For provided, the reasoning is about compile-time vs runtime, not about
dependency inheritance.

</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-core</artifactId>
Expand Down Expand Up @@ -175,6 +181,13 @@
<source>21</source>
<target>21</target>
<release>21</release>
<annotationProcessorPaths>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>1.18.34</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
Expand Down
Loading