You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds a separate sub-menu system for rendering DeluxeMenus content into the player's lower inventory area, while keeping normal GUI menus under gui_menus.
CommandPanels conversion has been removed from this PR as out of scope. MiniMessage menu text support is also not included here and will be tracked under the Paper-only draft PR (#228).
Inventory sub menus
Sub menus are loaded separately from normal GUI menus:
The action opens the named sub_menus entry into the lower 36 inventory slots of the currently open menu. If the current GUI did not enable hide_player_inventory, DeluxeMenus snapshots and hides the player's inventory before rendering the sub menu, then restores it on close, quit, reload, shutdown, or death.
Sub menus can also use existing GUI actions:
click_commands:
- "[openguimenu] dungeon"
When a sub menu opens a normal GUI menu, the lower sub menu is preserved if the new GUI does not define its own player_inventory_menu. If the new GUI does define one, that configured sub menu replaces the current lower panel to avoid duplicate or conflicting inventory overlays.
Sub menus can also open other sub menus with [open_gui_inventory] <sub-menu>.
Please could the CommandPanels converter be removed, as this is out of scope of the plugin.
MiniMessage support will also be tracked under the Paper only draft PR (#228), as spigot doesn't have full Component support within menus. please remove this also.
Once this is done we will review the code. Thank you!
Please could the CommandPanels converter be removed, as this is out of scope of the plugin. MiniMessage support will also be tracked under the Paper only draft PR (#228), as spigot doesn't have full Component support within menus. please remove this also.
Once this is done we will review the code. Thank you!
Thanks for your reply! I've deleted the commandpanel convert and modified a few things. Thanks again, I really appreciate it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a separate sub-menu system for rendering DeluxeMenus content into the player's lower inventory area, while keeping normal GUI menus under
gui_menus.CommandPanels conversion has been removed from this PR as out of scope. MiniMessage menu text support is also not included here and will be tracked under the Paper-only draft PR (#228).
Inventory sub menus
Sub menus are loaded separately from normal GUI menus:
Sub menu files live in:
Sub menus are capped to the lower inventory surface: slots
0-35. They are not listed as normal GUI menus and do not register open commands.A normal GUI can attach a default lower panel with:
bottom_menuis also supported as an alias.Dynamic lower panel action
This PR adds:
The action opens the named
sub_menusentry into the lower 36 inventory slots of the currently open menu. If the current GUI did not enablehide_player_inventory, DeluxeMenus snapshots and hides the player's inventory before rendering the sub menu, then restores it on close, quit, reload, shutdown, or death.Sub menus can also use existing GUI actions:
When a sub menu opens a normal GUI menu, the lower sub menu is preserved if the new GUI does not define its own
player_inventory_menu. If the new GUI does define one, that configured sub menu replaces the current lower panel to avoid duplicate or conflicting inventory overlays.Sub menus can also open other sub menus with
[open_gui_inventory] <sub-menu>.Validation
./gradlew.bat buildsuccessfully.