fix(refresh): mark items so DupeFixer can catch them#280
Merged
Conversation
BlitzOffline
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu#openMenustamps everyItemStackwithMenuItemMarker#markbefore placing it in the inventory, soDupeFixer.onPickup/onDropandMenu#cleanInventorycan recognize and remove a DeluxeMenus item that ever escapes the menu.MenuHolder#refreshMenurebuilds the same stacks but skips that call. Any item served after a refresh ([refresh]action,refresh_interval, periodic update task) slips past the dupe fixer.Fix
Mirror the null-check + mark pattern already used in
Menu#openMenu:for (MenuItem item : active) { ItemStack iStack = item.getItemStack(this); + if (iStack == null) { + continue; + } + + iStack = plugin.getMenuItemMarker().mark(iStack); int slot = item.options().slot();Demonstration
dm.mp4
A companion plugin rewrites each menu item's lore every tick with its live PDC keys, so the marker state is observable in-game without dumping NBT.
Menu config:
On
/demo, the diamond's lore readsdeluxemenus:dm.(no PDC keys). Right-click ([openmenu]) restores it, sinceMenu#openMenualready marks correctly.deluxemenus:dmacross any number of refreshes.