fix(Uncle-Fungus): suppress redundant Toxic Spores combat log message#2941
fix(Uncle-Fungus): suppress redundant Toxic Spores combat log message#2941clawctrl1 wants to merge 1 commit intoFreezingMoon:masterfrom
Conversation
Fixes FreezingMoon#2171 ## Problem When Uncle Fungus' passive ability Toxic Spores triggers on melee attack, the combat log shows "Uncle Fungus uses Toxic Spores" twice - once from the ability trigger and once from the effect application. ## Solution Use empty string as effect title (similar to Tentacle Bush FreezingMoon#1947) to suppress the redundant message. The effect is still applied correctly, but the log only shows the meaningful message about regrowth reduction. ## Changes - Changed Effect title from `this.title` to `''` in Toxic Spores activate() - Added comment explaining the redundancy suppression pattern Closes FreezingMoon#2171
|
Someone is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
Implementation NotesThis fix follows the same pattern used in Tentacle Bush (#1947), where an empty title prevents duplicate combat log messages. Key insight: When an Effect is created with an empty title, it still applies the alterations correctly but doesn't generate a redundant log entry. This is cleaner than trying to suppress the message after the fact. Testing: The fix ensures that when Uncle Fungus' Toxic Spores passive triggers on melee attack, the combat log shows only the meaningful message about regrowth reduction, not the duplicate "Uncle Fungus uses Toxic Spores" entry. This improves the combat log readability without affecting gameplay mechanics. |
1 participant
Fixes #2171
Problem
When Uncle Fungus' passive ability Toxic Spores triggers on melee attack, the combat log shows "Uncle Fungus uses Toxic Spores" twice - once from the ability trigger and once from the effect application.
Solution
Use empty string as effect title (similar to Tentacle Bush #1947) to suppress the redundant message. The effect is still applied correctly, but the log only shows the meaningful message about regrowth reduction.
Changes
this.titleto''in Toxic Spores activate()Closes #2171