Skip to content

Express fold nodes using accumulator nodes#540

Draft
knoepfel wants to merge 1 commit intoFramework-R-D:mainfrom
knoepfel:fix-fold-caching
Draft

Express fold nodes using accumulator nodes#540
knoepfel wants to merge 1 commit intoFramework-R-D:mainfrom
knoepfel:fix-fold-caching

Conversation

@knoepfel
Copy link
Copy Markdown
Member

This PR replaces the caching mechanism for fold results with a similar mechanism as used in #118.


Resolves #359

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/core/detail/accumulator_node.hpp 94.73% 1 Missing and 4 partials ⚠️
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   86.74%   85.80%   -0.95%     
==========================================
  Files         142      143       +1     
  Lines        5033     3755    -1278     
  Branches      631      644      +13     
==========================================
- Hits         4366     3222    -1144     
+ Misses        452      313     -139     
- Partials      215      220       +5     
Flag Coverage Δ
unittests 85.80% <94.73%> (-0.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/fold/send.hpp 100.00% <ø> (ø)
phlex/core/detail/accumulator_node.hpp 94.73% <94.73%> (ø)

... and 113 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6acbf1a...3d19c63. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Includes adjusting infrastructure for "sendable" types
@knoepfel knoepfel marked this pull request as draft April 23, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change fold-result caching to use multilayer_join_node

1 participant