Fix NRT errors and enable TreatWarningsAsErrors

build/common.props

@@ -16,6 +16,7 @@
     <NoWarn>$(NoWarn);CS1591</NoWarn>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <LangVersion>latest</LangVersion>
+    <Nullable>enable</Nullable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageOutputPath>$(SolutionDir)artifacts</PackageOutputPath>
     <PackageIcon>foundatio-icon.png</PackageIcon>

samples/Foundatio.SampleJob/PingQueueJob.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Threading;
 using System.Threading.Tasks;
 using Exceptionless;
@@ -26,9 +26,9 @@ public PingQueueJob(IQueue<PingRequest> queue, ICacheClient cacheClient, IMessag
 
     public int RunCount => _runCount;
 
-    protected override Task<ILock> GetQueueEntryLockAsync(IQueueEntry<PingRequest> queueEntry, CancellationToken cancellationToken = new CancellationToken())
+    protected override Task<ILock?> GetQueueEntryLockAsync(IQueueEntry<PingRequest> queueEntry, CancellationToken cancellationToken = new CancellationToken())
     {
-        return _locker.AcquireAsync(String.Concat("pull:", queueEntry.Value.Id),
+        return _locker.AcquireAsync(String.Concat("pull:", queueEntry.Value!.Id),
             TimeSpan.FromMinutes(30),
             TimeSpan.FromSeconds(1));
     }
@@ -40,16 +40,16 @@ protected override async Task<JobResult> ProcessQueueEntryAsync(QueueEntryContex
         _logger.LogInformation("Got {RunCount} ping. Sending pong!", RunCount.ToOrdinal());
         await Task.Delay(TimeSpan.FromMilliseconds(1)).AnyContext();
 
-        if (RandomData.GetBool(context.QueueEntry.Value.PercentChanceOfException))
+        if (RandomData.GetBool(context.QueueEntry.Value!.PercentChanceOfException))
             throw new ApplicationException("Boom!");
 
         return JobResult.Success;
     }
 }
 
-public class PingRequest
+public record PingRequest
 {
-    public string Data { get; set; }
-    public string Id { get; set; }
-    public int PercentChanceOfException { get; set; } = 0;
+    public required string Data { get; set; }
+    public required string Id { get; set; }
+    public int PercentChanceOfException { get; set; }
 }

samples/Foundatio.SampleJob/Program.cs

@@ -7,7 +7,7 @@ namespace Foundatio.SampleJob;
 
 public class Program
 {
-    private static ILogger _logger;
+    private static ILogger _logger = null!;
 
     public static int Main()
     {
@@ -27,7 +27,7 @@ private static void HandleEchoMessage(EchoMessage m)
     }
 }
 
-public class EchoMessage
+public record EchoMessage
 {
-    public string Message { get; set; }
+    public required string Message { get; set; }
 }

samples/Foundatio.SampleJob/SampleServiceProvider.cs

@@ -11,7 +11,7 @@ namespace Foundatio.SampleJob;
 
 public class SampleServiceProvider
 {
-    public static IServiceProvider Create(ILoggerFactory loggerFactory)
+    public static IServiceProvider Create(ILoggerFactory? loggerFactory)
     {
         var container = new ServiceCollection();
 

samples/Foundatio.SampleJobClient/Foundatio.SampleJobClient.csproj

@@ -8,7 +8,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Foundatio.Xunit.v3" Version="13.0.0-beta3.32" />
+    <PackageReference Include="Foundatio.Xunit.v3" Version="13.0.0-beta3.43" />
   </ItemGroup>
 
   <ItemGroup>

samples/Foundatio.SampleJobClient/Program.cs

@@ -12,10 +12,10 @@ namespace Foundatio.SampleJobClient;
 
 public class Program
 {
-    private static IQueue<PingRequest> _queue;
-    private static IMessageBus _messageBus;
-    private static TestLogger _loggerFactory;
-    private static ILogger _logger;
+    private static IQueue<PingRequest> _queue = null!;
+    private static IMessageBus _messageBus = null!;
+    private static TestLogger _loggerFactory = null!;
+    private static ILogger _logger = null!;
     private static bool _isRunning = true;
     private static CancellationTokenSource _continuousEnqueueTokenSource = new();
 
@@ -210,14 +210,14 @@ private static ConsoleColor GetColor(LogEntry logEntry)
     }
 }
 
-public class EchoMessage
+public record EchoMessage
 {
-    public string Message { get; set; }
+    public required string Message { get; set; }
 }
 
-public class PingRequest
+public record PingRequest
 {
-    public string Data { get; set; }
+    public required string Data { get; set; }
     public string Id { get; set; } = Guid.NewGuid().ToString("N");
-    public int PercentChanceOfException { get; set; } = 0;
+    public int PercentChanceOfException { get; set; }
 }