add premake FindHeaderWithSubDir#2803
Merged
purerosefallen merged 1 commit intoFluorohydride:masterfrom May 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Some dependency header file paths are located in subfolders, while the relevant code directly uses the file name. For example:
In
miniaudio_libopus.c,#include <opusfile.h>refers to the file located at/usr/include/opus/opusfile.h.Therefore, we need to provide the full
/usr/include/opuspath.Currently, Premake5 does not support searching in subfolders. Using
os.findheader("opus/opusfile.h")returns/usr/include, so we have to manually appendopusafterward.However, the current code throws an "attempt to concatenate a nil value" error when
os.findheaderreturns nil.Solution:
Add an additional wrapper, or wait until premake/premake-core#2469 gets merged.
path.joinis a function provided by Premake.