feat(review): show security badge whenever security review is enabled#84
Merged
Conversation
Contributor
|
Droid finished @factory-nizar's task —— View job Review SummaryThis PR makes dual-flow security review deterministic by running a dedicated security candidates pass and merging it with code-review candidates before validation. The main remaining risk is silently losing security findings if the security candidates file isn't produced. |
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
factory-nizar
force-pushed
the
fix/automatic-security-review
branch
from
3a07a3b to
1ddb23e
Compare
The security shield badge previously only appeared when the validator approved at least one [security]-tagged comment. That conflated 'security review found issues' with 'security review ran', and meant clean PRs gave no positive signal that the security pass had executed. Move the badge prepending out of the validator prompt and into the post-execution update-comment-link step so it is added deterministically whenever automatic_security_review=true. The badge now means 'security review was performed', regardless of whether any findings exist. - updateCommentBody accepts securityReviewRan and prepends the shield badge (with a guard against double-prepending if an earlier step already added it) - update-comment-link.ts reads AUTOMATIC_SECURITY_REVIEW from env - action.yml passes inputs.automatic_security_review through to the post-step - review-validator-prompt no longer instructs the LLM to prepend the badge (removes a discretionary, findings-gated path) Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
factory-nizar
force-pushed
the
fix/automatic-security-review
branch
from
1ddb23e to
d35c2f9
Compare
factory-nizar
changed the title
jonathan-factory
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the security shield badge deterministic: it now appears on the tracking comment whenever
automatic_security_review: trueis set, instead of only when the validator approved at least one[security]-tagged finding.Previously a clean PR gave no signal that the security pass had run. Now it does.
The prepend moves from the validator prompt to the post-execution
update-comment-linkstep, with a guard against double-prepending.Tests
@dev, used to confirm this PR doesn't change the security pass itself.