Skip to content

Remove: ModuleProgram struct#323

Open
LesterEvSe wants to merge 1 commit into
BlockstreamResearch:masterfrom
LesterEvSe:cleanup/module-program-struct
Open

Remove: ModuleProgram struct#323
LesterEvSe wants to merge 1 commit into
BlockstreamResearch:masterfrom
LesterEvSe:cleanup/module-program-struct

Conversation

@LesterEvSe
Copy link
Copy Markdown
Collaborator

Resolves issue #321

@LesterEvSe LesterEvSe requested a review from KyrylR May 14, 2026 10:00
@LesterEvSe LesterEvSe self-assigned this May 14, 2026
@LesterEvSe LesterEvSe requested a review from delta1 as a code owner May 14, 2026 10:00
@LesterEvSe LesterEvSe added the enhancement New feature or request label May 14, 2026
@LesterEvSe LesterEvSe linked an issue May 14, 2026 that may be closed by this pull request
@LesterEvSe LesterEvSe force-pushed the cleanup/module-program-struct branch from 135b917 to 7ded9ef Compare May 14, 2026 11:03
@LesterEvSe LesterEvSe added the invalid This doesn't seem right label May 14, 2026
@KyrylR
Copy link
Copy Markdown
Collaborator

KyrylR commented May 15, 2026

We should mention this change in a CHANGELOG.md

@KyrylR
Copy link
Copy Markdown
Collaborator

KyrylR commented May 15, 2026

Found a few leftovers:

cargo test --manifest-path fuzz/Cargo.toml --bin parse_witness_json_rtt fails with E0599 because of the second one

@LesterEvSe
Copy link
Copy Markdown
Collaborator Author

* AST-side module analysis scaffolding looks unused now: [`ast.rs#L407-L455`](https://github.com/BlockstreamResearch/SimplicityHL/blob/7ded9ef447acacdacfc560eed6e8e042e6cc1c7e/src/ast.rs#L407-L455), [`ast.rs#L1571-L1609`](https://github.com/BlockstreamResearch/SimplicityHL/blob/7ded9ef447acacdacfc560eed6e8e042e6cc1c7e/src/ast.rs#L1571-L1609)

Yes, that's right. But the fundamentals of this can be used when solving this issue: #318

@LesterEvSe LesterEvSe force-pushed the cleanup/module-program-struct branch from 7ded9ef to d76b98f Compare May 15, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused ModuleProgram

2 participants