You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.
Thank you @frankwg for this contribution. The use case is valid — OLM/OCP deployments need a way to bootstrap the operator's ConfigMaps and Secret before the main container starts, and the initContainer approach is a reasonable pattern for that.
However, we are putting this PR on hold for now for the following reasons:
Stale / merge conflicts. The PR targets 0.24.0 (April 2024) and currently has merge conflicts. The codebase has changed substantially since then and the PR would need a full rebase before we can review it properly.
Hardcoded default credentials.HandleSecretCreation creates the clickhouse-operator Secret with the default password hardcoded in the source. We'd want a cleaner approach here — either deriving the value from an existing config source or making it configurable.
Error handling.getConfigsFrom() calls log.Fatal on read errors, which terminates the process without a meaningful exit code path. Errors should be propagated up and handled by the caller.
We'd welcome a rebased version of this PR against the current master branch with the above points addressed. In the meantime we'll keep this open for tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes OLM based deployment can also use configmaps and secret to host those configurations.
Thanks for taking the time to contribute to
clickhouse-operator!Please, read carefully instructions on how to make a Pull Request.
This will help a lot for maintainers to adopt your Pull Request.
Important items to consider before making a Pull Request
Please check items PR complies to:
next-releasebranch, not intomasterbranch1. More info--
1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into
masterbranch, but it has to be confirmed by project's maintainer.