[PWGDQ,PWGEM] Tune MC TPC PID response to data#16146
Open
JinjooSeo wants to merge 2 commits intoAliceO2Group:masterfrom
Open
[PWGDQ,PWGEM] Tune MC TPC PID response to data#16146JinjooSeo wants to merge 2 commits intoAliceO2Group:masterfrom
JinjooSeo wants to merge 2 commits intoAliceO2Group:masterfrom
Conversation
Contributor
JinjooSeo
commented
May 7, 2026
JinjooSeo
commented
- (nSigma - meanMC) * (sigmaMC / sigmaData) + meanData for MC PID calibration
- Rename calibration variables to explicit MC / Data naming
JinjooSeo
requested review from
alibuild,
dsekihat,
feisenhu,
hscheid,
iarsene,
jokonig,
lucamicheletti93,
mcoquet642,
mikesas and
rbailhac
as code owners
|
O2 linter results: ❌ 1561 errors, |
JinjooSeo
changed the title
github-actions
Bot
changed the title
Collaborator
|
Error while checking build/O2Physics/staging for 4f5dfad at 2026-05-07 13:18: Full log here. |
iarsene
approved these changes
May 7, 2026
vkucera
reviewed
May 7, 2026
Comment on lines
+379
to
+385
| switch (species) { | ||
| case 0: | ||
| calibMeanSim = kTPCElectronMeanMC; | ||
| calibSigmaSim = kTPCElectronSigmaMC; | ||
| calibMeanData = kTPCElectronMeanData; | ||
| calibSigmaData = kTPCElectronSigmaData; | ||
| break; |
Collaborator
There was a problem hiding this comment.
These hard-coded case numbers are meaningless.
Collaborator
vkucera
reviewed
May 8, 2026
Comment on lines
+409
to
+412
| TH2* calibMeanSimHist = reinterpret_cast<TH2*>(fgCalibs[calibMeanSim]); | ||
| TH2* calibSigmaSimHist = reinterpret_cast<TH2*>(fgCalibs[calibSigmaSim]); | ||
| TH2* calibMeanDataHist = reinterpret_cast<TH2*>(fgCalibs[calibMeanData]); | ||
| TH2* calibSigmaDataHist = reinterpret_cast<TH2*>(fgCalibs[calibSigmaData]); |
Collaborator
There was a problem hiding this comment.
Don't use reinterpret_cast. Use dynamic_cast instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.