Add support for "--variant -1" style syntax for rez-build#2103
Add support for "--variant -1" style syntax for rez-build#2103sanikache wants to merge 2 commits into
Conversation
Signed-off-by: Ibrahim Sani <Ibrahim.Sani@dreamworks.com>
|
One failing test in the jobs, that I see at a glance (I pulled linux 3.10 as a sample) |
|
Taking a look . . |
|
It's the change in |
Signed-off-by: Ibrahim Sani <Ibrahim.Sani@dreamworks.com>
|
It looks like there is no test for copy_package on a non-variants package. I added one to cover that. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2103 +/- ##
==========================================
+ Coverage 60.65% 60.70% +0.04%
==========================================
Files 164 164
Lines 20584 20594 +10
Branches 3579 3585 +6
==========================================
+ Hits 12485 12501 +16
+ Misses 7224 7219 -5
+ Partials 875 874 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Overall I'm happy, I would ask the question if maybe, since the build_process and package_copy is almost the same, if there is a sane/easy way to extract, put the variant-counting/set/invalid logic in a shared location, and call it, but the code is subtly different so perhaps it would not be completely simple? Happy to discuss. |
|
For sure, let me take a look . . |
This pull request adds support for specifying negative variant indices (e.g., --variants -1) in rez build and copy workflows.
Negative indices are now accepted to select variants counting backward from the end, mirroring Python’s negative indexing convention.