mr,issue,snippet: make shorthand flags deprecated

All commands with --list, --close and --browse flags, also has the actual
subcommand for each of them. I've seen users getting confused because the
flags in the `list` command can't be used with the shorthand, and tbh,
typing `list` is easier than `--list` (the same is valid for the others
flags).

IMHO the shorthand as a whole should be deprecated, avoiding user confusion
and, possibly, dead code for getting maintained.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>

Author: bmeneg

cmd/issue.go

@@ -36,7 +36,10 @@ var issueCmd = &cobra.Command{
 
 func init() {
 	issueCmd.Flags().BoolP("list", "l", false, "list issues on a remote")
+	issueCmd.Flags().MarkDeprecated("list", "use the \"list\" subcommand instead")
 	issueCmd.Flags().BoolP("browse", "b", false, "view issue <id> in a browser")
+	issueCmd.Flags().MarkDeprecated("browse", "use the \"browse\" subcommand instead")
 	issueCmd.Flags().StringP("close", "d", "", "close issue <id> on remote")
+	issueCmd.Flags().MarkDeprecated("close", "use the \"close\" subcommand instead")
 	RootCmd.AddCommand(issueCmd)
 }

cmd/mr.go

@@ -37,7 +37,10 @@ var mrCmd = &cobra.Command{
 
 func init() {
 	mrCmd.Flags().BoolP("list", "l", false, "list merge requests on a remote")
+	mrCmd.Flags().MarkDeprecated("list", "use the \"list\" subcommand instead")
 	mrCmd.Flags().BoolP("browse", "b", false, "view merge request <id> in a browser")
+	mrCmd.Flags().MarkDeprecated("browse", "use the \"browse\" subcommand instead")
 	mrCmd.Flags().StringP("close", "d", "", "close merge request <id> on remote")
+	mrCmd.Flags().MarkDeprecated("close", "use the \"close\" subcommand instead")
 	RootCmd.AddCommand(mrCmd)
 }

cmd/snippet.go

@@ -52,8 +52,11 @@ var (
 func init() {
 	snippetCmd.PersistentFlags().BoolVarP(&global, "global", "g", false, "create as a personal snippet")
 	snippetCmd.Flags().BoolP("list", "l", false, "list snippets")
+	snippetCmd.Flags().MarkDeprecated("list", "use the \"list\" subcommand instead")
 	snippetCmd.Flags().BoolP("browse", "b", false, "browse snippets")
+	snippetCmd.Flags().MarkDeprecated("browse", "use the \"browse\" subcommand instead")
 	snippetCmd.Flags().StringP("delete", "d", "", "delete snippet with id")
+	snippetCmd.Flags().MarkDeprecated("delete", "use the \"delete\" subcommand instead")
 	// Create flags added in snippetCreate.go
 	RootCmd.AddCommand(snippetCmd)
 }