Merge pull request #76 from bestander/e2e-tests-3

e2e tests for fbsource integration

Author: sebmck

test/commands/install.js

@@ -15,6 +15,8 @@ import { run as uninstall } from "../../src/cli/commands/uninstall.js";
 import Config from "../../src/config.js";
 import * as fs from "../../src/util/fs.js";
 import assert from "assert";
+import semver from "semver";
+
 
 let test = require("ava");
 let path = require("path");
@@ -335,6 +337,60 @@ test("upgrade scenario", () => {
   }, clean);
 });
 
+test("upgrade scenario 2 (with sub dependencies)", async () => {
+  // mime-types@2.0.0 is saved in local mirror and gets updated to mime-types@2.1.11
+  // files in mirror, fbkpm.lock, package.json and node_modules should reflect that
+
+  let mirrorPath = "mirror-for-offline";
+  let fixture = "install-upgrade-scenario-2";
+  let cwd = path.join(fixturesLoc, fixture);
+  await fs.copy(path.join(cwd, "fbkpm.lock.before"), path.join(cwd, "fbkpm.lock"));
+  await fs.copy(path.join(cwd, "package.json.before"), path.join(cwd, "package.json"));
+
+  return run({}, [], fixture, async (config) => {
+    assert(semver.satisfies(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+      "~1.0.1")
+    );
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+      "2.0.0"
+    );
+
+    return run({save: true}, ["mime-types@2.1.11"], fixture, async (config) => {
+      assert(semver.satisfies(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+        "~1.23.0"
+      ));
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+        "2.1.11"
+      );
+
+      let lockFileWritten = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+      let lockFileLines = lockFileWritten.split("\n").filter((line) => !!line);
+      assert.equal(lockFileLines[0], "mime-db@~1.23.0:");
+      assert.notEqual(lockFileLines[3].indexOf("resolved mime-db-"), -1);
+      assert.equal(lockFileLines[4], "mime-types@2.1.11:");
+      assert.notEqual(lockFileLines[7].indexOf("resolved mime-types-2.1.11.tgz"), -1);
+
+      let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+      assert.equal(mirror.length, 4);
+      let newFilesInMirror = mirror.filter((elem) => {
+        return elem.relative !== "mime-db-1.0.3.tgz" && elem.relative !== "mime-types-2.0.0.tgz";
+      });
+
+      assert.equal(newFilesInMirror.length, 2);
+
+      await fs.unlink(newFilesInMirror[0].absolute);
+      await fs.unlink(newFilesInMirror[1].absolute);
+
+      await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+      await fs.unlink(path.join(config.cwd, "package.json"));
+    });
+  });
+});
+
 test("downgrade scenario", () => {
   // left-pad first installed 1.1.0 then downgraded to 0.0.9
   // files in mirror, fbkpm.lock, package.json and node_modules should reflect that
@@ -535,7 +591,6 @@ test("uninstall should remove subdependencies", () => {
     await uninstall(config, reporter, {}, ["dep-a"]);
 
     assert(!await fs.exists(path.join(config.cwd, "node_modules/dep-a")));
-    // TODO dep-b did not get removed
     assert(!await fs.exists(path.join(config.cwd, "node_modules/dep-b")));
     assert(await fs.exists(path.join(config.cwd, "node_modules/dep-c")));
 
@@ -562,4 +617,274 @@ test("uninstall should remove subdependencies", () => {
   });
 });
 
+test("install --save should add missing deps to fbkpm and mirror (PR import scenario)", async () => {
+  let mirrorPath = "mirror-for-offline";
+  let fixture = "install-import-pr";
+  let cwd = path.join(fixturesLoc, fixture);
+  await fs.copy(path.join(cwd, "fbkpm.lock.before"), path.join(cwd, "fbkpm.lock"));
+
+  return run({save: true}, [], fixture, async (config, reporter) => {
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/mime-types/package.json"))).version, "2.0.0");
+    assert(semver.satisfies(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/mime-db/package.json"))).version, "~1.0.1"));
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/fake-fbkpm-dependency/package.json"))).version, "1.0.1");
+
+    let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+    assert.equal(mirror.length, 3);
+    assert.equal(mirror[0].relative, "fake-fbkpm-dependency-1.0.1.tgz");
+    assert.equal(mirror[1].relative.indexOf("mime-db-1.0."), 0);
+    assert.equal(mirror[2].relative, "mime-types-2.0.0.tgz");
+
+    let lockFileContent = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+    let lockFileLines = lockFileContent.split("\n").filter((line) => !!line);
+    // TODO error here
+    assert.equal(lockFileLines.length, 14);
+    assert.equal(lockFileLines[4].indexOf("mime-db@"), 0);
+    assert.equal(lockFileLines[8].indexOf("mime-types@2.0.0"), 0);
+
+    await fs.unlink(path.join(mirror[1].absolute));
+    await fs.unlink(path.join(mirror[2].absolute));
+    await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+  });
+});
+
+
+test("install --save should update a dependency to fbkpm and mirror (PR import scenario 2)", async () => {
+  // mime-types@2.0.0 is saved in local mirror and gets updated to mime-types@2.1.11 via
+  // a change in package.json,
+  // files in mirror, fbkpm.lock, package.json and node_modules should reflect that
+
+  let mirrorPath = "mirror-for-offline";
+  let fixture = "install-import-pr-2";
+  let cwd = path.join(fixturesLoc, fixture);
+  await fs.copy(path.join(cwd, "fbkpm.lock.before"), path.join(cwd, "fbkpm.lock"));
+  await fs.copy(path.join(cwd, "package.json.before"), path.join(cwd, "package.json"));
+
+  return run({}, [], fixture, async (config) => {
+    assert(semver.satisfies(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+      "~1.0.1")
+    );
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+      "2.0.0"
+    );
+
+    await fs.unlink(path.join(config.cwd, "package.json"));
+    await fs.copy(path.join(cwd, "package.json.after"), path.join(cwd, "package.json"));
+
+    return run({save: true}, [], fixture, async (config) => {
+      assert(semver.satisfies(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+        "~1.23.0"
+      ));
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+        "2.1.11"
+      );
+
+      let lockFileWritten = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+      let lockFileLines = lockFileWritten.split("\n").filter((line) => !!line);
+      assert.equal(lockFileLines[0], "mime-db@~1.23.0:");
+      assert.notEqual(lockFileLines[3].indexOf("resolved mime-db-"), -1);
+      assert.equal(lockFileLines[4], "mime-types@2.1.11:");
+      assert.notEqual(lockFileLines[7].indexOf("resolved mime-types-2.1.11.tgz"), -1);
+
+      let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+      assert.equal(mirror.length, 4);
+      let newFilesInMirror = mirror.filter((elem) => {
+        return elem.relative !== "mime-db-1.0.3.tgz" && elem.relative !== "mime-types-2.0.0.tgz";
+      });
+
+      assert.equal(newFilesInMirror.length, 2);
+
+      await fs.unlink(newFilesInMirror[0].absolute);
+      await fs.unlink(newFilesInMirror[1].absolute);
+
+      await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+      await fs.unlink(path.join(config.cwd, "package.json"));
+    });
+  });
+});
+
+test("install --initMirror should add init mirror deps from package.json", async () => {
+  let mirrorPath = "mirror-for-offline";
+  let fixture = "install-init-mirror";
+
+  // initMirror gets converted to save flag in cli/install.js
+  return run({save: true}, [], fixture, async (config, reporter) => {
+    assert.equal(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/mime-types/package.json"))).version, "2.0.0");
+    assert(semver.satisfies(JSON.parse(await fs.readFile(path.join(config.cwd,
+      "node_modules/mime-db/package.json"))).version, "~1.0.1"));
+
+    let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+    assert.equal(mirror.length, 2);
+    assert.equal(mirror[0].relative.indexOf("mime-db-1.0."), 0);
+    assert.equal(mirror[1].relative, "mime-types-2.0.0.tgz");
+
+    let lockFileContent = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+    let lockFileLines = lockFileContent.split("\n").filter((line) => !!line);
+    assert.equal(lockFileLines.length, 10);
+    assert.equal(lockFileLines[0].indexOf("mime-db@"), 0);
+    assert.equal(lockFileLines[4].indexOf("mime-types@2.0.0"), 0);
+
+    await fs.unlink(path.join(config.cwd, mirrorPath));
+    await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+  });
+});
+
+test("install --save with new dependency should be deterministic", async () => {
+  // mime-types@2.0.0->mime-db@1.0.3 is saved in local mirror and is deduped
+  // install mime-db@1.23.0 should move mime-db@1.0.3 deep into mime-types
+
+  let mirrorPath = "mirror-for-offline";
+  let fixture = "install-deterministic";
+  let cwd = path.join(fixturesLoc, fixture);
+  await fs.copy(path.join(cwd, "fbkpm.lock.before"), path.join(cwd, "fbkpm.lock"));
+  await fs.copy(path.join(cwd, "package.json.before"), path.join(cwd, "package.json"));
+
+  return run({}, [], fixture, async (config) => {
+    assert(semver.satisfies(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+      "~1.0.1")
+    );
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+      "2.0.0"
+    );
+
+    return run({save: true}, ["mime-db@1.23.0"], fixture, async (config) => {
+      assert(semver.satisfies(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+        "~1.23.0"
+      ));
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+        "2.0.0"
+      );
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd,
+          "node_modules/mime-types/node_modules/mime-db/package.json"))).version,
+        "1.0.3"
+      );
+      assert.deepEqual(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "package.json"))).dependencies, {
+          "mime-types": "2.0.0",
+          "mime-db": "1.23.0"
+        }
+      );
+
+      let lockFileWritten = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+      let lockFileLines = lockFileWritten.split("\n").filter((line) => !!line);
+      assert.equal(lockFileLines.length, 14);
+
+
+      let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+      assert.equal(mirror.length, 3);
+      assert.equal(mirror[1].relative, "mime-db-1.23.0.tgz");
+
+      await fs.unlink(mirror[1].absolute);
+      await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+      await fs.unlink(path.join(config.cwd, "package.json"));
+    });
+  });
+});
+
+test("install --save with new dependency should be deterministic 2", async () => {
+  // mime-types@2.0.0->mime-db@1.0.1 is saved in local mirror and is deduped
+  // install mime-db@1.0.3 should replace mime-db@1.0.1 in root
+
+  let mirrorPath = "mirror-for-offline";
+  let fixture = "install-deterministic-2";
+  let cwd = path.join(fixturesLoc, fixture);
+  await fs.copy(path.join(cwd, "fbkpm.lock.before"), path.join(cwd, "fbkpm.lock"));
+  await fs.copy(path.join(cwd, "package.json.before"), path.join(cwd, "package.json"));
+
+  return run({}, [], fixture, async (config) => {
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+      "1.0.1"
+    );
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+      "2.0.0"
+    );
+
+    return run({save: true}, ["mime-db@1.0.3"], fixture, async (config) => {
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-db/package.json"))).version,
+        "1.0.3"
+      );
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/mime-types/package.json"))).version,
+        "2.0.0"
+      );
+      assert(!await fs.exists(path.join(config.cwd, "node_modules/mime-types/node-modules/mime-db")));
+      assert.deepEqual(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "package.json"))).dependencies, {
+          "mime-types": "2.0.0",
+          "mime-db": "1.0.3"
+        }
+      );
+
+      let lockFileWritten = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+      let lockFileLines = lockFileWritten.split("\n").filter((line) => !!line);
+      assert.equal(lockFileLines.length, 10);
+
+
+      let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+      assert.equal(mirror.length, 3);
+      assert.equal(mirror[1].relative, "mime-db-1.0.3.tgz");
+
+      await fs.unlink(mirror[1].absolute);
+      await fs.unlink(path.join(config.cwd, "fbkpm.lock"));
+      await fs.unlink(path.join(config.cwd, "package.json"));
+    });
+  });
+});
+
+
+test("install --save should ignore cache", () => {
+  // left-pad@1.1.0 gets installed without --save
+  // left-pad@1.1.0 gets installed with --save
+  // files in mirror, fbkpm.lock, package.json and node_modules should reflect that
+
+  let mirrorPath = "mirror-for-offline";
+
+  let fixture = "install-save-to-mirror-when-cached";
+  return run({}, ["left-pad@1.1.0"], fixture, async (config) => {
+    assert.equal(
+      JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/left-pad/package.json"))).version,
+      "1.1.0"
+    );
+
+    return run({save: true}, ["left-pad@1.1.0"], fixture, async (config) => {
+      assert.equal(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "node_modules/left-pad/package.json"))).version,
+        "1.1.0"
+      );
+      assert.deepEqual(
+        JSON.parse(await fs.readFile(path.join(config.cwd, "package.json"))).dependencies,
+        {"left-pad": "1.1.0"}
+      );
 
+      let lockFileWritten = await fs.readFile(path.join(config.cwd, "fbkpm.lock"));
+      let lockFileLines = lockFileWritten.split("\n").filter((line) => !!line);
+      assert.equal(lockFileLines[0], "left-pad@1.1.0:");
+      assert.equal(lockFileLines.length, 4);
+      assert.notEqual(lockFileLines[3].indexOf("resolved left-pad-1.1.0.tgz"), -1);
+
+      throw new Error("AA")
+
+      let mirror = await fs.walk(path.join(config.cwd, mirrorPath));
+      assert.equal(mirror.length, 1);
+      assert.equal(mirror[0].relative, "left-pad-1.1.0.tgz");
+      await fs.unlink(path.join(config.cwd, mirrorPath));
+      await fs.unlink(path.join(config.cwd, "package.json"));
+
+    });
+  });
+});

test/fixtures/install/install-deterministic-2/.npmrc

@@ -0,0 +1 @@
+kpm-offline-mirror=./mirror-for-offline

test/fixtures/install/install-deterministic-2/fbkpm.lock.before

@@ -0,0 +1,10 @@
+mime-db@~1.0.1:
+  name mime-db
+  version "1.0.1"
+  resolved mime-db-1.0.1.tgz#35d99b0965967253bb30633a7d07a8de9975a952
+mime-types@2.0.0:
+  name mime-types
+  version "2.0.0"
+  resolved mime-types-2.0.0.tgz#4a85688446a4d94a03909e0ae292766744a3c313
+  dependencies:
+    mime-db "~1.0.1"

test/fixtures/install/install-deterministic-2/mirror-for-offline/mime-db-1.0.1.tgz

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "mime-types": "2.0.0"
+  }
+}

test/fixtures/install/install-deterministic-2/mirror-for-offline/mime-types-2.0.0.tgz

@@ -0,0 +1 @@
+kpm-offline-mirror=./mirror-for-offline

test/fixtures/install/install-deterministic-2/package.json.before

@@ -0,0 +1,10 @@
+mime-db@~1.0.1:
+  name mime-db
+  version "1.0.3"
+  resolved mime-db-1.0.3.tgz#5680b12300b3cecea5620f20f269ee80f2632d81
+mime-types@2.0.0:
+  name mime-types
+  version "2.0.0"
+  resolved mime-types-2.0.0.tgz#4a85688446a4d94a03909e0ae292766744a3c313
+  dependencies:
+    mime-db "~1.0.1"