Bugfixes and typos in dynamic models

Author: x-tabdeveloping

turftopic/models/cluster.py

@@ -338,8 +338,6 @@ def fit_transform_dynamic(
         time_labels, self.time_bin_edges = self.bin_timestamps(
             timestamps, bins
         )
-        n_comp, n_vocab = self.components_.shape
-        n_bins = len(self.time_bin_edges) - 1
         if hasattr(self, "components_"):
             doc_topic_matrix = label_binarize(
                 self.labels_, classes=self.classes_
@@ -348,7 +346,9 @@ def fit_transform_dynamic(
             doc_topic_matrix = self.fit_transform(
                 raw_documents, embeddings=embeddings
             )
-        self.temporal_components = np.zeros(
+        n_comp, n_vocab = self.components_.shape
+        n_bins = len(self.time_bin_edges) - 1
+        self.temporal_components_ = np.zeros(
             (n_bins, n_comp, n_vocab), dtype=doc_topic_matrix.dtype
         )
         self.temporal_importance_ = np.zeros((n_bins, n_comp))

turftopic/models/gmm.py

@@ -182,7 +182,7 @@ def fit_transform_dynamic(
         document_term_matrix = self.vectorizer.transform(raw_documents)
         n_comp, n_vocab = self.components_.shape
         n_bins = len(self.time_bin_edges) - 1
-        self.temporal_components = np.zeros(
+        self.temporal_components_ = np.zeros(
             (n_bins, n_comp, n_vocab), dtype=document_term_matrix.dtype
         )
         self.temporal_importance_ = np.zeros((n_bins, n_comp))

turftopic/models/keynmf.py

@@ -248,7 +248,9 @@ def fit_transform_dynamic(
             keywords = self.extract_keywords(
                 raw_documents, embeddings=embeddings
             )
-        time_labels, self.time_bin_edges = bin_timestamps(timestamps, bins)
+        time_labels, self.time_bin_edges = self.bin_timestamps(
+            timestamps, bins
+        )
         doc_topic_matrix = self.model.fit_transform_dynamic(
             keywords, time_labels, self.time_bin_edges
         )