wolfcrypt/benchmark/benchmark.c: fixes for clang-analyzer-deadcode.DeadStores in bench_xmss_sign_verify();

douzzer · douzzer · commit fa30d3ae0be7 · 2024-04-30T22:48:48.000-05:00
wolfcrypt/test/test.c: fix for invalidPrintfArgType_sint in xmss_test_verify_only().
diff --git a/wolfcrypt/benchmark/benchmark.c b/wolfcrypt/benchmark/benchmark.c
@@ -10071,12 +10071,10 @@ static void bench_xmss_sign_verify(const char * params)
 
     if (freeRng) {
         wc_FreeRng(&rng);
-        freeRng = 0;
     }
 
     if (freeKey) {
         wc_XmssKey_Free(&key);
-        freeKey = 0;
     }
 
     return;
diff --git a/wolfcrypt/test/test.c b/wolfcrypt/test/test.c
@@ -38381,7 +38381,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t xmss_test_verify_only(void)
     }
 
     if (pub_len != XMSS_SHA256_PUBLEN) {
-        printf("error: xmss pub len %d, expected %d\n", pub_len,
+        printf("error: xmss pub len %u, expected %d\n", pub_len,
                XMSS_SHA256_PUBLEN);
         return WC_TEST_RET_ENC_EC(pub_len);
     }

Original file line number	Diff line number	Diff line change
`@@ -10071,12 +10071,10 @@ static void bench_xmss_sign_verify(const char * params)`
`10071`	`10071`
`10072`	`10072`	`if (freeRng) {`
`10073`	`10073`	`wc_FreeRng(&rng);`
`10074`		`- freeRng = 0;`
`10075`	`10074`	`}`
`10076`	`10075`
`10077`	`10076`	`if (freeKey) {`
`10078`	`10077`	`wc_XmssKey_Free(&key);`
`10079`		`- freeKey = 0;`
`10080`	`10078`	`}`
`10081`	`10079`
`10082`	`10080`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -38381,7 +38381,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t xmss_test_verify_only(void)`
`38381`	`38381`	`}`
`38382`	`38382`
`38383`	`38383`	`if (pub_len != XMSS_SHA256_PUBLEN) {`
`38384`		`- printf("error: xmss pub len %d, expected %d\n", pub_len,`
	`38384`	`+ printf("error: xmss pub len %u, expected %d\n", pub_len,`
`38385`	`38385`	`XMSS_SHA256_PUBLEN);`
`38386`	`38386`	`return WC_TEST_RET_ENC_EC(pub_len);`
`38387`	`38387`	`}`