Fix F381 to harden wc_MakeDsaKey

embhorn · embhorn · commit f093268bb946 · 2026-03-05T15:15:41.000-06:00
diff --git a/wolfcrypt/src/dsa.c b/wolfcrypt/src/dsa.c
@@ -227,7 +227,7 @@ int wc_MakeDsaKey(WC_RNG *rng, DsaKey *dsa)
         dsa->type = DSA_PRIVATE;
 
     if (err != MP_OKAY) {
-        mp_clear(&dsa->x);
+        mp_forcezero(&dsa->x);
         mp_clear(&dsa->y);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ int wc_MakeDsaKey(WC_RNG rng, DsaKey dsa)`
`227`	`227`	`dsa->type = DSA_PRIVATE;`
`228`	`228`
`229`	`229`	`if (err != MP_OKAY) {`
`230`		`- mp_clear(&dsa->x);`
	`230`	`+ mp_forcezero(&dsa->x);`
`231`	`231`	`mp_clear(&dsa->y);`
`232`	`232`	`}`
`233`	`233`