Skip to content

Commit ebbeb6c

Browse files
Merge pull request #6984 from res0nance/pqc-crash-fix
tls: return immediately if kyber_id2type() fails
2 parents 665469f + 98789dc commit ebbeb6c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/tls.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8396,7 +8396,7 @@ static int TLSX_KeyShare_ProcessPqc(WOLFSSL* ssl, KeyShareEntry* keyShareEntry)
83968396
ret = kyber_id2type(oqs_group, &type);
83978397
if (ret != 0) {
83988398
WOLFSSL_MSG("Invalid OQS algorithm specified.");
8399-
ret = BAD_FUNC_ARG;
8399+
return BAD_FUNC_ARG;
84008400
}
84018401
if (ret == 0) {
84028402
ret = wc_KyberKey_Init(type, kem, ssl->heap, INVALID_DEVID);
@@ -8887,7 +8887,7 @@ static int server_generate_pqc_ciphertext(WOLFSSL* ssl,
88878887
ret = kyber_id2type(oqs_group, &type);
88888888
if (ret != 0) {
88898889
WOLFSSL_MSG("Invalid Kyber algorithm specified.");
8890-
ret = BAD_FUNC_ARG;
8890+
return BAD_FUNC_ARG;
88918891
}
88928892

88938893
if (ret == 0) {

0 commit comments

Comments
 (0)