Skip to content

Commit e1ee5e4

Browse files
committed
linuxkm: spruce up arch-dependent CFLAGS setup in linuxkm/Kbuild; add "failed:" to error messages in km_AesGcmEncrypt() and km_AesGcmDecrypt().
1 parent f228a85 commit e1ee5e4

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

linuxkm/Kbuild

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ WOLFSSL_CFLAGS += -ffreestanding -Wframe-larger-than=$(MAX_STACK_FRAME_SIZE) -is
3232

3333
ifeq "$(KERNEL_ARCH)" "x86"
3434
WOLFSSL_CFLAGS += -mpreferred-stack-boundary=4
35+
else ifeq "$(KERNEL_ARCH)" "aarch64"
36+
WOLFSSL_CFLAGS += -mno-outline-atomics
37+
else ifeq "$(KERNEL_ARCH)" "arm64"
38+
WOLFSSL_CFLAGS += -mno-outline-atomics
3539
endif
3640

3741
obj-m := libwolfssl.o
@@ -47,15 +51,15 @@ $(obj)/linuxkm/module_exports.o: $(WOLFSSL_OBJ_TARGETS)
4751
# this mechanism only works in kernel 5.x+ (fallback to hardcoded value)
4852
hostprogs := linuxkm/get_thread_size
4953
always-y := $(hostprogs)
54+
55+
HOST_EXTRACFLAGS += $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(KBUILD_CFLAGS) -static -fno-omit-frame-pointer
56+
5057
# "-mindirect-branch=keep -mfunction-return=keep" to avoid "undefined reference
5158
# to `__x86_return_thunk'" on CONFIG_RETHUNK kernels (5.19.0-rc7)
52-
ifeq "$(KERNEL_ARCH)" "aarch64"
53-
HOST_EXTRACFLAGS += $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(KBUILD_CFLAGS) -static -fno-omit-frame-pointer
54-
else
55-
HOST_EXTRACFLAGS += $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(KBUILD_CFLAGS) -static -fno-omit-frame-pointer -mindirect-branch=keep -mfunction-return=keep
59+
ifeq "$(KERNEL_ARCH)" "x86"
60+
HOST_EXTRACFLAGS += -mindirect-branch=keep -mfunction-return=keep
5661
endif
5762

58-
5963
# this rule is needed to get build to succeed in 4.x (get_thread_size still doesn't get built)
6064
$(obj)/linuxkm/get_thread_size: $(src)/linuxkm/get_thread_size.c
6165

linuxkm/lkcapi_glue.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ static int km_AesGcmEncrypt(struct aead_request *req)
579579

580580
err = skcipher_walk_aead_encrypt(&walk, req, false);
581581
if (unlikely(err)) {
582-
pr_err("%s: skcipher_walk_aead_encrypt: %d\n",
582+
pr_err("%s: skcipher_walk_aead_encrypt failed: %d\n",
583583
crypto_tfm_alg_driver_name(crypto_aead_tfm(tfm)), err);
584584
return -1;
585585
}
@@ -685,7 +685,7 @@ static int km_AesGcmDecrypt(struct aead_request *req)
685685

686686
err = skcipher_walk_aead_decrypt(&walk, req, false);
687687
if (unlikely(err)) {
688-
pr_err("%s: skcipher_walk_aead_decrypt: %d\n",
688+
pr_err("%s: skcipher_walk_aead_decrypt failed: %d\n",
689689
crypto_tfm_alg_driver_name(crypto_aead_tfm(tfm)), err);
690690
return err;
691691
}

0 commit comments

Comments
 (0)