Merge pull request #6399 from bigbrett/zd16083-ocsp-double-free

JacobBarthelmeh · web-flow · commit 9cca571c1d85 · 2023-05-12T13:50:54.000-06:00
fix double free in InitOCSPRequest
diff --git a/wolfcrypt/src/asn.c b/wolfcrypt/src/asn.c
@@ -35260,6 +35260,7 @@ int InitOcspRequest(OcspRequest* req, DecodedCert* cert, byte useNonce,
                                                      DYNAMIC_TYPE_OCSP_REQUEST);
             if (req->url == NULL) {
                 XFREE(req->serial, req->heap, DYNAMIC_TYPE_OCSP);
+                req->serial = NULL;
                 return MEMORY_E;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -35260,6 +35260,7 @@ int InitOcspRequest(OcspRequest* req, DecodedCert* cert, byte useNonce,`
`35260`	`35260`	`DYNAMIC_TYPE_OCSP_REQUEST);`
`35261`	`35261`	`if (req->url == NULL) {`
`35262`	`35262`	`XFREE(req->serial, req->heap, DYNAMIC_TYPE_OCSP);`
	`35263`	`+ req->serial = NULL;`
`35263`	`35264`	`return MEMORY_E;`
`35264`	`35265`	`}`
`35265`	`35266`