Update logic to avoid clang-tidy warning.

billphipps · billphipps · commit 5e1db686e1a6 · 2024-09-24T13:14:00.000-04:00
diff --git a/wolfcrypt/src/cmac.c b/wolfcrypt/src/cmac.c
@@ -318,7 +318,8 @@ int wc_CmacFinalNoFree(Cmac* cmac, byte* out, word32* outSz)
         else {
             /* ensure we will have a valid remainder value */
             if (cmac->bufferSz > AES_BLOCK_SIZE) {
-                return BAD_STATE_E;
+                ret = BAD_STATE_E;
+                break;
             }
             remainder = AES_BLOCK_SIZE - cmac->bufferSz;
 

Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,8 @@ int wc_CmacFinalNoFree(Cmac* cmac, byte* out, word32* outSz)`
`318`	`318`	`else {`
`319`	`319`	`/* ensure we will have a valid remainder value */`
`320`	`320`	`if (cmac->bufferSz > AES_BLOCK_SIZE) {`
`321`		`- return BAD_STATE_E;`
	`321`	`+ ret = BAD_STATE_E;`
	`322`	`+ break;`
`322`	`323`	`}`
`323`	`324`	`remainder = AES_BLOCK_SIZE - cmac->bufferSz;`
`324`	`325`