Skip to content

Commit 5c9ad35

Browse files
authored
Merge pull request #8904 from anhu/bigger_header
Fix missing dashes on the end of header and footer.
2 parents b8aa4bd + 72ec402 commit 5c9ad35

3 files changed

Lines changed: 19 additions & 14 deletions

File tree

wolfcrypt/src/asn.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26172,8 +26172,8 @@ wcchar END_PUB_KEY = "-----END PUBLIC KEY-----";
2617226172
#if defined(HAVE_FALCON)
2617326173
wcchar BEGIN_FALCON_LEVEL1_PRIV = "-----BEGIN FALCON_LEVEL1 PRIVATE KEY-----";
2617426174
wcchar END_FALCON_LEVEL1_PRIV = "-----END FALCON_LEVEL1 PRIVATE KEY-----";
26175-
wcchar BEGIN_FALCON_LEVEL5_PRIV = "-----BEGIN FALCON_LEVEL5 PRIVATE KEY-----";
26176-
wcchar END_FALCON_LEVEL5_PRIV = "-----END FALCON_LEVEL5 PRIVATE KEY-----";
26175+
wcchar BEGIN_FALCON_LEVEL5_PRIV = "-----BEGIN FALCON_LEVEL5 PRIVATE KEY-----";
26176+
wcchar END_FALCON_LEVEL5_PRIV = "-----END FALCON_LEVEL5 PRIVATE KEY-----";
2617726177
#endif /* HAVE_FALCON */
2617826178
#if defined(HAVE_DILITHIUM)
2617926179
#ifdef WOLFSSL_DILITHIUM_FIPS204_DRAFT

wolfssl/wolfcrypt/dilithium.h

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -144,9 +144,9 @@
144144
#define DILITHIUM_LEVEL5_PUB_KEY_DER_SIZE 2614
145145
#define DILITHIUM_LEVEL5_PRV_KEY_DER_SIZE 4924
146146
#define DILITHIUM_LEVEL5_BOTH_KEY_DER_SIZE 7520
147-
/* PEM size with the header "-----BEGIN PRIVATE KEY-----" and
148-
* the footer "-----END PRIVATE KEY-----" */
149-
#define DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE 10239
147+
/* PEM size with the header "-----BEGIN ML_DSA_LEVEL5 PRIVATE KEY-----" and
148+
* the footer "-----END ML_DSA_LEVEL5 PRIVATE KEY-----" */
149+
#define DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE 10267
150150

151151
#define ML_DSA_LEVEL2_KEY_SIZE 2560
152152
#define ML_DSA_LEVEL2_SIG_SIZE 2420
@@ -183,8 +183,8 @@
183183
#define ML_DSA_LEVEL5_PUB_KEY_DER_SIZE DILITHIUM_LEVEL5_PUB_KEY_DER_SIZE
184184
#define ML_DSA_LEVEL5_PRV_KEY_DER_SIZE DILITHIUM_LEVEL5_PRV_KEY_DER_SIZE
185185
#define ML_DSA_LEVEL5_BOTH_KEY_DER_SIZE DILITHIUM_LEVEL5_BOTH_KEY_DER_SIZE
186-
/* PEM size with the header "-----BEGIN PRIVATE KEY-----" and
187-
* the footer "-----END PRIVATE KEY-----" */
186+
/* PEM size with the header "-----BEGIN ML_DSA_LEVEL5 PRIVATE KEY-----" and
187+
* the footer "-----END ML_DSA_LEVEL5 PRIVATE KEY-----" */
188188
#define ML_DSA_LEVEL5_BOTH_KEY_PEM_SIZE DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE
189189

190190

@@ -574,9 +574,9 @@
574574
#define DILITHIUM_LEVEL5_PUB_KEY_DER_SIZE 2614
575575
#define DILITHIUM_LEVEL5_PRV_KEY_DER_SIZE 4924
576576
#define DILITHIUM_LEVEL5_BOTH_KEY_DER_SIZE 7520
577-
/* PEM size with the header "-----BEGIN PRIVATE KEY-----" and
578-
* the footer "-----END PRIVATE KEY-----" */
579-
#define DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE 10239
577+
/* PEM size with the header "-----BEGIN ML_DSA_LEVEL5 PRIVATE KEY-----" and
578+
* the footer "-----END ML_DSA_LEVEL5 PRIVATE KEY-----" */
579+
#define DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE 10267
580580

581581
#define ML_DSA_LEVEL2_KEY_SIZE OQS_SIG_ml_dsa_44_ipd_length_secret_key
582582
#define ML_DSA_LEVEL2_SIG_SIZE OQS_SIG_ml_dsa_44_ipd_length_signature
@@ -613,8 +613,8 @@
613613
#define ML_DSA_LEVEL5_PUB_KEY_DER_SIZE DILITHIUM_LEVEL5_PUB_KEY_DER_SIZE
614614
#define ML_DSA_LEVEL5_PRV_KEY_DER_SIZE DILITHIUM_LEVEL5_PRV_KEY_DER_SIZE
615615
#define ML_DSA_LEVEL5_BOTH_KEY_DER_SIZE DILITHIUM_LEVEL5_BOTH_KEY_DER_SIZE
616-
/* PEM size with the header "-----BEGIN PRIVATE KEY-----" and
617-
* the footer "-----END PRIVATE KEY-----" */
616+
/* PEM size with the header "-----BEGIN ML_DSA_LEVEL5 PRIVATE KEY-----" and
617+
* the footer "-----END ML_DSA_LEVEL5 PRIVATE KEY-----" */
618618
#define ML_DSA_LEVEL5_BOTH_KEY_PEM_SIZE DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE
619619

620620
#endif
@@ -627,8 +627,8 @@
627627
#define DILITHIUM_MAX_PUB_KEY_DER_SIZE DILITHIUM_LEVEL5_PUB_KEY_DER_SIZE
628628
#define DILITHIUM_MAX_PRV_KEY_DER_SIZE DILITHIUM_LEVEL5_PRV_KEY_DER_SIZE
629629
#define DILITHIUM_MAX_BOTH_KEY_DER_SIZE DILITHIUM_LEVEL5_BOTH_KEY_DER_SIZE
630-
/* PEM size with the header "-----BEGIN PRIVATE KEY-----" and
631-
* the footer "-----END PRIVATE KEY-----" */
630+
/* PEM size with the header "-----BEGIN ML_DSA_LEVEL5 PRIVATE KEY-----" and
631+
* the footer "-----END ML_DSA_LEVEL5 PRIVATE KEY-----" */
632632
#define DILITHIUM_MAX_BOTH_KEY_PEM_SIZE DILITHIUM_LEVEL5_BOTH_KEY_PEM_SIZE
633633

634634

wolfssl/wolfcrypt/types.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2050,7 +2050,12 @@ enum Max_ASN {
20502050
/* Maximum DER digest ASN header size */
20512051
/* Max X509 header length indicates the
20522052
* max length + 2 ('\n', '\0') */
2053+
#if defined(HAVE_FALCON) || defined(HAVE_DILITHIUM) || defined(HAVE_SPHINCS)
2054+
MAX_X509_HEADER_SZ = (48 + 2), /* Maximum PEM Header/Footer Size */
2055+
#else
20532056
MAX_X509_HEADER_SZ = (37 + 2), /* Maximum PEM Header/Footer Size */
2057+
#endif
2058+
20542059
#if defined(HAVE_FALCON) || defined(HAVE_DILITHIUM)
20552060
MAX_PUBLIC_KEY_SZ = MAX_PQC_PUBLIC_KEY_SZ + MAX_ALGO_SZ + MAX_SEQ_SZ * 2,
20562061
#else

0 commit comments

Comments
 (0)