Skip to content

Commit 52658c5

Browse files
committed
OCSP Error Return
1. In CheckOcspResponse(), remove the existing check for UNKNOWN certificate status. Given the values of ret and ocsp->error, unknown won't get checked. 2. Separated checks for UKNOWN and REJECTED for logging purposes. Return that as an error. 3. Anything else should be a failure.
1 parent 195c14c commit 52658c5

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

src/ocsp.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -409,10 +409,14 @@ int CheckOcspResponse(WOLFSSL_OCSP *ocsp, byte *response, int responseSz,
409409
end:
410410
if (ret == 0 && validated == 1) {
411411
WOLFSSL_MSG("New OcspResponse validated");
412-
} else if ((ret == ocsp->error) && (ocspResponse->single->status->status == CERT_UNKNOWN)) {
412+
}
413+
else if (ret == OCSP_CERT_REVOKED) {
414+
WOLFSSL_MSG("OCSP revoked");
415+
}
416+
else if (ret == OCSP_CERT_UNKNOWN) {
413417
WOLFSSL_MSG("OCSP unknown");
414-
ret = OCSP_CERT_UNKNOWN;
415-
} else if (ret != OCSP_CERT_REVOKED) {
418+
}
419+
else {
416420
WOLFSSL_MSG("OCSP lookup failure");
417421
ret = OCSP_LOOKUP_FAIL;
418422
}

0 commit comments

Comments
 (0)