Skip to content

Commit 38d191c

Browse files
author
Andras Fekete
committed
More PR comment fixes
1 parent a31d8c5 commit 38d191c

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

wolfcrypt/src/dilithium.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7934,8 +7934,10 @@ int wc_dilithium_check_key(dilithium_key* key)
79347934
}
79357935
}
79367936

7937-
/* Dispose of allocated memory. */
7938-
XFREE(s1, key->heap, DYNAMIC_TYPE_DILITHIUM);
7937+
if (key != NULL) {
7938+
/* Dispose of allocated memory. */
7939+
XFREE(s1, key->heap, DYNAMIC_TYPE_DILITHIUM);
7940+
}
79397941
#else
79407942
/* Validate parameter. */
79417943
if (key == NULL) {

wolfcrypt/src/rsa.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5081,11 +5081,13 @@ int wc_MakeRsaKey(RsaKey* key, int size, long e, WC_RNG* rng)
50815081

50825082
#if !defined(WOLFSSL_CRYPTOCELL) && !defined(WOLFSSL_SE050)
50835083
#ifdef WOLFSSL_SMALL_STACK
5084-
XFREE(p, key->heap, DYNAMIC_TYPE_RSA);
5085-
XFREE(q, key->heap, DYNAMIC_TYPE_RSA);
5086-
XFREE(tmp1, key->heap, DYNAMIC_TYPE_RSA);
5087-
XFREE(tmp2, key->heap, DYNAMIC_TYPE_RSA);
5088-
XFREE(tmp3, key->heap, DYNAMIC_TYPE_RSA);
5084+
if (key != NULL) {
5085+
XFREE(p, key->heap, DYNAMIC_TYPE_RSA);
5086+
XFREE(q, key->heap, DYNAMIC_TYPE_RSA);
5087+
XFREE(tmp1, key->heap, DYNAMIC_TYPE_RSA);
5088+
XFREE(tmp2, key->heap, DYNAMIC_TYPE_RSA);
5089+
XFREE(tmp3, key->heap, DYNAMIC_TYPE_RSA);
5090+
}
50895091
#elif defined(WOLFSSL_CHECK_MEM_ZERO)
50905092
mp_memzero_check(p);
50915093
mp_memzero_check(q);

0 commit comments

Comments
 (0)