Skip to content

Commit 2dd8e71

Browse files
committed
Fix static analyzer possible leak
crl would never be null there but clean up code to make sure newcrl->crlLock gets free'd
1 parent a3bf7a6 commit 2dd8e71

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/crl.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -829,6 +829,7 @@ static int DupX509_CRL(WOLFSSL_X509_CRL *dupl, const WOLFSSL_X509_CRL* crl)
829829
int wolfSSL_X509_STORE_add_crl(WOLFSSL_X509_STORE *store, WOLFSSL_X509_CRL *newcrl)
830830
{
831831
WOLFSSL_X509_CRL *crl;
832+
int ret = 0;
832833

833834
WOLFSSL_ENTER("wolfSSL_X509_STORE_add_crl");
834835
if (store == NULL || newcrl == NULL || store->cm == NULL)
@@ -843,11 +844,10 @@ int wolfSSL_X509_STORE_add_crl(WOLFSSL_X509_STORE *store, WOLFSSL_X509_CRL *newc
843844
WOLFSSL_MSG("wc_LockRwLock_Rd failed");
844845
return BAD_MUTEX_E;
845846
}
846-
if (DupX509_CRL(crl, newcrl) != 0) {
847-
if (crl != NULL) {
848-
wc_UnLockRwLock(&newcrl->crlLock);
849-
FreeCRL(crl, 1);
850-
}
847+
ret = DupX509_CRL(crl, newcrl);
848+
wc_UnLockRwLock(&newcrl->crlLock);
849+
if (ret != 0) {
850+
FreeCRL(crl, 1);
851851
return WOLFSSL_FAILURE;
852852
}
853853
wc_UnLockRwLock(&newcrl->crlLock);

0 commit comments

Comments
 (0)