Fix possible memory leak

Andras Fekete · Andras Fekete · commit 2877b7be505c · 2023-10-27T15:31:28.000-04:00
diff --git a/src/x509.c b/src/x509.c
@@ -14098,7 +14098,8 @@ int wolfSSL_X509_REQ_add1_attr_by_NID(WOLFSSL_X509 *req,
             }
         }
         ret = wolfSSL_sk_push(req->reqAttributes, attr);
-        if (ret != WOLFSSL_SUCCESS) {
+        if ((ret != WOLFSSL_SUCCESS) || (req->reqAttributes->type == STACK_TYPE_CIPHER)) {
+            /* CIPHER type makes a copy */
             wolfSSL_X509_ATTRIBUTE_free(attr);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -14098,7 +14098,8 @@ int wolfSSL_X509_REQ_add1_attr_by_NID(WOLFSSL_X509 *req,`
`14098`	`14098`	`}`
`14099`	`14099`	`}`
`14100`	`14100`	`ret = wolfSSL_sk_push(req->reqAttributes, attr);`
`14101`		`- if (ret != WOLFSSL_SUCCESS) {`
	`14101`	`+ if ((ret != WOLFSSL_SUCCESS) \|\| (req->reqAttributes->type == STACK_TYPE_CIPHER)) {`
	`14102`	`+ /* CIPHER type makes a copy */`
`14102`	`14103`	`wolfSSL_X509_ATTRIBUTE_free(attr);`
`14103`	`14104`	`}`
`14104`	`14105`	`}`