Merge pull request #7587 from douzzer/20240524-pq-clang-tidy

dgarske · web-flow · commit 200f309e0e89 · 2024-05-24T16:40:11.000-07:00
20240524-pq-clang-tidy
diff --git a/wolfcrypt/src/dilithium.c b/wolfcrypt/src/dilithium.c
@@ -489,6 +489,7 @@ static int parse_private_key(const byte* priv, word32 privSz,
     /* At this point, it is still a PKCS8 private key. */
     if ((ret = ToTraditionalInline(priv, &idx, privSz)) < 0) {
         /* ignore error, did not have PKCS8 header */
+        (void)ret;
     }
 
     /* Now it is a octet_string(concat(priv,pub)) */
diff --git a/wolfcrypt/src/falcon.c b/wolfcrypt/src/falcon.c
@@ -470,6 +470,7 @@ static int parse_private_key(const byte* priv, word32 privSz,
     /* At this point, it is still a PKCS8 private key. */
     if ((ret = ToTraditionalInline(priv, &idx, privSz)) < 0) {
         /* ignore error, did not have PKCS8 header */
+        (void)ret;
     }
 
     /* Now it is a octet_string(concat(priv,pub)) */
diff --git a/wolfcrypt/src/sphincs.c b/wolfcrypt/src/sphincs.c
@@ -432,6 +432,7 @@ static int parse_private_key(const byte* priv, word32 privSz,
     /* At this point, it is still a PKCS8 private key. */
     if ((ret = ToTraditionalInline(priv, &idx, privSz)) < 0) {
         /* ignore error, did not have PKCS8 header */
+        (void)ret;
     }
 
     /* Now it is a octet_string(concat(priv,pub)) */

Original file line number	Diff line number	Diff line change
`@@ -489,6 +489,7 @@ static int parse_private_key(const byte* priv, word32 privSz,`
`489`	`489`	`/* At this point, it is still a PKCS8 private key. */`
`490`	`490`	`if ((ret = ToTraditionalInline(priv, &idx, privSz)) < 0) {`
`491`	`491`	`/* ignore error, did not have PKCS8 header */`
	`492`	`+ (void)ret;`
`492`	`493`	`}`
`493`	`494`
`494`	`495`	`/* Now it is a octet_string(concat(priv,pub)) */`
Original file line number	Diff line number	Diff line change
`@@ -470,6 +470,7 @@ static int parse_private_key(const byte* priv, word32 privSz,`
`470`	`470`	`/* At this point, it is still a PKCS8 private key. */`
`471`	`471`	`if ((ret = ToTraditionalInline(priv, &idx, privSz)) < 0) {`
`472`	`472`	`/* ignore error, did not have PKCS8 header */`
	`473`	`+ (void)ret;`
`473`	`474`	`}`
`474`	`475`
`475`	`476`	`/* Now it is a octet_string(concat(priv,pub)) */`
Original file line number	Diff line number	Diff line change
`@@ -432,6 +432,7 @@ static int parse_private_key(const byte* priv, word32 privSz,`
`432`	`432`	`/* At this point, it is still a PKCS8 private key. */`
`433`	`433`	`if ((ret = ToTraditionalInline(priv, &idx, privSz)) < 0) {`
`434`	`434`	`/* ignore error, did not have PKCS8 header */`
	`435`	`+ (void)ret;`
`435`	`436`	`}`
`436`	`437`
`437`	`438`	`/* Now it is a octet_string(concat(priv,pub)) */`