save heap before FreeRsaKey in delete

JeremiahM37 · JeremiahM37 · commit 1dddc1daf5c0 · 2026-04-13T15:50:52.000Z
diff --git a/wolfcrypt/src/rsa.c b/wolfcrypt/src/rsa.c
@@ -270,11 +270,13 @@ RsaKey* wc_NewRsaKey_Label(const char* label, void* heap, int devId,
 
 int wc_DeleteRsaKey(RsaKey* key, RsaKey** key_p)
 {
+    void* heap;
     if (key == NULL) {
         return BAD_FUNC_ARG;
     }
+    heap = key->heap;
     wc_FreeRsaKey(key);
-    XFREE(key, key->heap, DYNAMIC_TYPE_RSA);
+    XFREE(key, heap, DYNAMIC_TYPE_RSA);
     if (key_p != NULL) {
         *key_p = NULL;
     }

Original file line number	Diff line number	Diff line change
`@@ -270,11 +270,13 @@ RsaKey* wc_NewRsaKey_Label(const char* label, void* heap, int devId,`
`270`	`270`
`271`	`271`	`int wc_DeleteRsaKey(RsaKey* key, RsaKey** key_p)`
`272`	`272`	`{`
	`273`	`+ void* heap;`
`273`	`274`	`if (key == NULL) {`
`274`	`275`	`return BAD_FUNC_ARG;`
`275`	`276`	`}`
	`277`	`+ heap = key->heap;`
`276`	`278`	`wc_FreeRsaKey(key);`
`277`		`- XFREE(key, key->heap, DYNAMIC_TYPE_RSA);`
	`279`	`+ XFREE(key, heap, DYNAMIC_TYPE_RSA);`
`278`	`280`	`if (key_p != NULL) {`
`279`	`281`	`*key_p = NULL;`
`280`	`282`	`}`