Skip to content

Commit 1681cb2

Browse files
committed
Dilithium: DER encoding fix
Underlying function SetAsymKeyDer() changed semantics. Update tests to reflect new behaviour.
1 parent 3b74a64 commit 1681cb2

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

tests/api.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33388,7 +33388,7 @@ static int test_wc_dilithium_der(void)
3338833388
ExpectIntEQ(wc_Dilithium_PublicKeyToDer(NULL, der , DILITHIUM_MAX_DER_SIZE,
3338933389
0), BAD_FUNC_ARG);
3339033390
ExpectIntEQ(wc_Dilithium_PublicKeyToDer(key , der , 0 ,
33391-
0), BUFFER_E);
33391+
0), BUFFER_E );
3339233392
/* Get length only. */
3339333393
ExpectIntEQ(wc_Dilithium_PublicKeyToDer(key , NULL, 0 ,
3339433394
0), pubLen);
@@ -33401,32 +33401,32 @@ static int test_wc_dilithium_der(void)
3340133401

3340233402
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(NULL, NULL,
3340333403
0 ), BAD_FUNC_ARG);
33404-
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(key , NULL,
33405-
0 ), BAD_FUNC_ARG);
33404+
ExpectIntGT(wc_Dilithium_PrivateKeyToDer(key , NULL,
33405+
0 ), 0);
3340633406
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(NULL, der ,
3340733407
0 ), BAD_FUNC_ARG);
3340833408
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(NULL, NULL,
3340933409
DILITHIUM_MAX_DER_SIZE), BAD_FUNC_ARG);
3341033410
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(NULL, der ,
3341133411
DILITHIUM_MAX_DER_SIZE), BAD_FUNC_ARG);
3341233412
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(key , der ,
33413-
0 ), BAD_FUNC_ARG);
33413+
0 ), BUFFER_E);
3341433414
/* Get length only. */
3341533415
ExpectIntEQ(wc_Dilithium_PrivateKeyToDer(key , NULL,
3341633416
DILITHIUM_MAX_DER_SIZE), privDerLen);
3341733417

3341833418
ExpectIntEQ(wc_Dilithium_KeyToDer(NULL, NULL, 0 ),
3341933419
BAD_FUNC_ARG);
33420-
ExpectIntEQ(wc_Dilithium_KeyToDer(key , NULL, 0 ),
33421-
BAD_FUNC_ARG);
33420+
ExpectIntGT(wc_Dilithium_KeyToDer(key , NULL, 0 ),
33421+
0 );
3342233422
ExpectIntEQ(wc_Dilithium_KeyToDer(NULL, der , 0 ),
3342333423
BAD_FUNC_ARG);
3342433424
ExpectIntEQ(wc_Dilithium_KeyToDer(NULL, NULL, DILITHIUM_MAX_DER_SIZE),
3342533425
BAD_FUNC_ARG);
3342633426
ExpectIntEQ(wc_Dilithium_KeyToDer(NULL, der , DILITHIUM_MAX_DER_SIZE),
3342733427
BAD_FUNC_ARG);
3342833428
ExpectIntEQ(wc_Dilithium_KeyToDer(key , der , 0 ),
33429-
BAD_FUNC_ARG);
33429+
BUFFER_E );
3343033430
/* Get length only. */
3343133431
ExpectIntEQ(wc_Dilithium_KeyToDer(key , NULL, DILITHIUM_MAX_DER_SIZE),
3343233432
keyDerLen);

0 commit comments

Comments
 (0)