Merge pull request #7673 from douzzer/20240621-fix-oqs_dilithium_make_key-leak

JacobBarthelmeh · web-flow · commit 0cf5421e5a2e · 2024-06-21T15:37:24.000-06:00
20240621-fix-oqs_dilithium_make_key-leak
diff --git a/wolfcrypt/src/dilithium.c b/wolfcrypt/src/dilithium.c
@@ -5427,6 +5427,10 @@ static int oqs_dilithium_make_key(dilithium_key* key, WC_RNG* rng)
         key->pubKeySet = 1;
     }
 
+    if (oqssig != NULL) {
+        OQS_SIG_free(oqssig);
+    }
+
     return ret;
 }
 #endif /* WOLFSSL_DILITHIUM_NO_MAKE_KEY */

Original file line number	Diff line number	Diff line change
`@@ -5427,6 +5427,10 @@ static int oqs_dilithium_make_key(dilithium_key* key, WC_RNG* rng)`
`5427`	`5427`	`key->pubKeySet = 1;`
`5428`	`5428`	`}`
`5429`	`5429`
	`5430`	`+ if (oqssig != NULL) {`
	`5431`	`+ OQS_SIG_free(oqssig);`
	`5432`	`+ }`
	`5433`	`+`
`5430`	`5434`	`return ret;`
`5431`	`5435`	`}`
`5432`	`5436`	`#endif /* WOLFSSL_DILITHIUM_NO_MAKE_KEY */`