Extend JsonType instead of reimplementing its functionality

Author: ausi

src/symfony/src/Doctrine/Type/AttestedCredentialDataType.php

@@ -6,10 +6,9 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\JsonType;
-use Doctrine\DBAL\Types\Type;
 use Webauthn\AttestedCredentialData;
 
-final class AttestedCredentialDataType extends Type
+final class AttestedCredentialDataType extends JsonType
 {
     use SerializerTrait;
 
@@ -31,22 +30,8 @@ public function convertToPHPValue($value, AbstractPlatform $platform): ?Attested
         return $this->deserialize($value, AttestedCredentialData::class);
     }
 
-    public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
-    {
-        return $platform->getJsonTypeDeclarationSQL($column);
-    }
-
     public function getName(): string
     {
         return 'attested_credential_data';
     }
-
-    public function requiresSQLCommentHint(AbstractPlatform $platform): bool
-    {
-        if (method_exists(JsonType::class, 'requiresSQLCommentHint')) {
-            return (new JsonType())->requiresSQLCommentHint($platform);
-        }
-
-        return false;
-    }
 }

src/symfony/src/Doctrine/Type/PublicKeyCredentialDescriptorType.php

@@ -6,10 +6,9 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\JsonType;
-use Doctrine\DBAL\Types\Type;
 use Webauthn\PublicKeyCredentialDescriptor;
 
-final class PublicKeyCredentialDescriptorType extends Type
+final class PublicKeyCredentialDescriptorType extends JsonType
 {
     use SerializerTrait;
 
@@ -31,22 +30,8 @@ public function convertToPHPValue($value, AbstractPlatform $platform): ?PublicKe
         return $this->deserialize($value, PublicKeyCredentialDescriptor::class);
     }
 
-    public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
-    {
-        return $platform->getJsonTypeDeclarationSQL($column);
-    }
-
     public function getName(): string
     {
         return 'public_key_credential_descriptor';
     }
-
-    public function requiresSQLCommentHint(AbstractPlatform $platform): bool
-    {
-        if (method_exists(JsonType::class, 'requiresSQLCommentHint')) {
-            return (new JsonType())->requiresSQLCommentHint($platform);
-        }
-
-        return false;
-    }
 }

src/symfony/src/Doctrine/Type/TrustPathDataType.php

@@ -6,10 +6,9 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\JsonType;
-use Doctrine\DBAL\Types\Type;
 use Webauthn\TrustPath\TrustPath;
 
-final class TrustPathDataType extends Type
+final class TrustPathDataType extends JsonType
 {
     use SerializerTrait;
 
@@ -31,22 +30,8 @@ public function convertToPHPValue($value, AbstractPlatform $platform): ?TrustPat
         return $this->deserialize($value, TrustPath::class);
     }
 
-    public function getSQLDeclaration(array $column, AbstractPlatform $platform): string
-    {
-        return $platform->getJsonTypeDeclarationSQL($column);
-    }
-
     public function getName(): string
     {
         return 'trust_path';
     }
-
-    public function requiresSQLCommentHint(AbstractPlatform $platform): bool
-    {
-        if (method_exists(JsonType::class, 'requiresSQLCommentHint')) {
-            return (new JsonType())->requiresSQLCommentHint($platform);
-        }
-
-        return false;
-    }
 }