#488 set socket perm 0660 in .defaults.yml

Author: bnfinet

.defaults.yml

@@ -9,6 +9,7 @@ vouch:
   testing: false
   listen: 0.0.0.0
   port: 9090
+  socket_mode: 0660 
   # document_root:
   # domains:
   allowAllUsers: false
@@ -18,7 +19,6 @@ vouch:
   writeTimeout: 15
   readTimeout: 15
   idleTimeout: 15
-
   tls:
     # cert:
     # key:

main.go

@@ -243,9 +243,6 @@ func listen() (lis net.Listener, cleanupFn func(), err error) {
 		return nil, nil, fmt.Errorf("listen %s: %w", socketPath, err)
 	}
 
-	if cfg.Cfg.SocketMode == 0 {
-		cfg.Cfg.SocketMode = 0777
-	}
 	mode := fs.FileMode(cfg.Cfg.SocketMode)
 	if err = os.Chmod(socketPath, mode); err != nil {
 		return nil, nil, fmt.Errorf("chmod socket file %s %#o", socketPath, mode)

main_test.go

@@ -1,13 +1,14 @@
 package main
 
 import (
-	"github.com/stretchr/testify/assert"
-	"github.com/vouch/vouch-proxy/pkg/cfg"
 	"io/fs"
 	"os"
 	"path/filepath"
 	"strings"
 	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/vouch/vouch-proxy/pkg/cfg"
 )
 
 func Test_listenUds(t *testing.T) {
@@ -27,7 +28,7 @@ func Test_listenUds(t *testing.T) {
 
 	fi, err := os.Stat(socketPath)
 	assert.NoError(t, err)
-	assert.Equal(t, fs.FileMode(0777), fi.Mode().Perm())
+	assert.Equal(t, fs.FileMode(0660), fi.Mode().Perm())
 
 	assert.NotNil(t, lis)
 	assert.NoError(t, lis.Close())